Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 2717553004: Create tool to print statistics about the file size usage of an RTC event log. (Closed)

Created:
3 years, 10 months ago by terelius
Modified:
3 years, 7 months ago
Reviewers:
philipel, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Create tool to print statistics about the file size usage of an RTC event log. BUG=webrtc:7502 Review-Url: https://codereview.webrtc.org/2717553004 Cr-Commit-Position: refs/heads/master@{#17932} Committed: https://chromium.googlesource.com/external/webrtc/+/ee37e86de8bde6c7af020f1b1d222c00ba9694a3

Patch Set 1 #

Patch Set 2 : Fix #

Patch Set 3 : Simplify code and output #

Patch Set 4 : Fix includes #

Patch Set 5 : Portable format specifier in printf. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+271 lines, -0 lines) Patch
M webrtc/logging/BUILD.gn View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
A webrtc/logging/rtc_event_log/rtc_event_log2stats.cc View 1 2 3 4 1 chunk +252 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (15 generated)
terelius
3 years, 8 months ago (2017-04-20 13:05:53 UTC) #11
philipel
Cool :) Could you paste example output, either as a comment or in the description?
3 years, 8 months ago (2017-04-20 13:11:21 UTC) #12
terelius
On 2017/04/20 13:11:21, philipel wrote: > Cool :) > > Could you paste example output, ...
3 years, 7 months ago (2017-04-28 13:00:49 UTC) #15
philipel
looks good to me (huehuehue), lgtm
3 years, 7 months ago (2017-04-28 14:08:51 UTC) #16
stefan-webrtc
rs-lgtm
3 years, 7 months ago (2017-04-28 14:15:06 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2717553004/80001
3 years, 7 months ago (2017-04-28 14:16:39 UTC) #19
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 14:48:26 UTC) #22
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/external/webrtc/+/ee37e86de8bde6c7af020f1b1...

Powered by Google App Engine
This is Rietveld 408576698