Noise generator abstract class and identity noise generator implemented.

Noise generator abstract class and identity noise generator implemented.

BUG=webrtc:7218
NOTRY=True

Review-Url: https://codereview.webrtc.org/2717243003
Cr-Commit-Position: refs/heads/master@{#17048}
Committed: https://chromium.googlesource.com/external/webrtc/+/4610ec7dddb9045a128e462799dc0d5d449eee87

[AleBzk, 2017-02-28 16:04:37]

Description was changed from

==========
Noise generator abstract class and identity noise generator implemented.

BUG=webrtc:7218
NOTRY=True
==========

to

==========
Noise generator abstract class and identity noise generator implemented.

BUG=webrtc:7218
NOTRY=True
==========

[AleBzk, 2017-02-28 16:04:37]

alessiob@webrtc.org changed reviewers:
+ mbonadei@webrtc.org

[AleBzk, 2017-02-28 16:15:18]

Ciao Mirko,

I'm working on a Python tool to evaluate the APM module in WebRTC. This is done
by also simulating different noise conditions. This CL contains the
implementation of the noise generator abstract class, which defines the
interface and shares some private methods useful for each generator (e.g., white
noise).

[mbonadei, 2017-03-01 23:42:05]

Ciao Alessio,

sorry for the delay!

I have only added a couple of cosmetic comments to align the code to the style
guide.

I read the code and your comments and I have been able to understand the meaning
of it even if I am not experienced enough to give you a solid feedback (on the
audio processing related part) on this.

But from what I can see it lgtm.

https://codereview.webrtc.org/2717243003/diff/1/webrtc/modules/audio_processi...
File
webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/noise_generation.py
(right):

https://codereview.webrtc.org/2717243003/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/noise_generation.py:15:
Abstract class responsible for the generation of noisy signals.
The first comment (the short description) should go on the same line as the """.

https://codereview.webrtc.org/2717243003/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/noise_generation.py:28:
Finally, note that a noice source can generate multiple input-reference pairs.
Typo "noice" -> "noise".

https://codereview.webrtc.org/2717243003/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/noise_generation.py:84:
Add noisy-reference signal pairs.
Same as before,  please move line 84 on the same line as """.

[AleBzk, 2017-03-02 13:07:00]

Thanks so much!
Everything has been addressed.

https://codereview.webrtc.org/2717243003/diff/1/webrtc/modules/audio_processi...
File
webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/noise_generation.py
(right):

https://codereview.webrtc.org/2717243003/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/noise_generation.py:15:
Abstract class responsible for the generation of noisy signals.
On 2017/03/01 23:42:04, mbonadei wrote:
> The first comment (the short description) should go on the same line as the
""".

Done.

https://codereview.webrtc.org/2717243003/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/noise_generation.py:28:
Finally, note that a noice source can generate multiple input-reference pairs.
On 2017/03/01 23:42:04, mbonadei wrote:
> Typo "noice" -> "noise".

Done.

https://codereview.webrtc.org/2717243003/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/noise_generation.py:84:
Add noisy-reference signal pairs.
On 2017/03/01 23:42:04, mbonadei wrote:
> Same as before,  please move line 84 on the same line as """.

Done.

[AleBzk, 2017-03-06 06:53:17]

The CQ bit was checked by alessiob@webrtc.org

[AleBzk, 2017-03-06 06:53:17]

The patchset sent to the CQ was uploaded after l-g-t-m from mbonadei@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2717243003/#ps60001 (title:
"rebase")

[commit-bot: I haz the power, 2017-03-06 06:53:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-06 06:56:00]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488783197436070,
"parent_rev": "21debb3ae819f91f4d7da6800502c4c628c01f46", "commit_rev":
"4610ec7dddb9045a128e462799dc0d5d449eee87"}

[commit-bot: I haz the power, 2017-03-06 06:56:02]

Description was changed from

==========
Noise generator abstract class and identity noise generator implemented.

BUG=webrtc:7218
NOTRY=True
==========

to

==========
Noise generator abstract class and identity noise generator implemented.

BUG=webrtc:7218
NOTRY=True

Review-Url: https://codereview.webrtc.org/2717243003
Cr-Commit-Position: refs/heads/master@{#17048}
Committed:
https://chromium.googlesource.com/external/webrtc/+/4610ec7dddb9045a128e46279...
==========

[commit-bot: I haz the power, 2017-03-06 06:56:03]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/4610ec7dddb9045a128e46279...