Avoid overflow in WebRtcSpl_DotProductWithScale

webrtc/common_audio/BUILD.gn

Index: webrtc/common_audio/BUILD.gn
diff --git a/webrtc/common_audio/BUILD.gn b/webrtc/common_audio/BUILD.gn
index a3cf046bb46ddb4dcdb655e7e3d83ef6c305d522..369f40607a8ed8cc43ddd17c7c1d05baab74500f 100644
--- a/webrtc/common_audio/BUILD.gn
+++ b/webrtc/common_audio/BUILD.gn
@@ -47,6 +47,7 @@ rtc_static_library("common_audio") {
     "resampler/resampler.cc",
     "resampler/sinc_resampler.cc",
     "resampler/sinc_resampler.h",
+    "signal_processing/dot_product_with_scale.cc",

[kwiberg-webrtc, 2017/02/28 12:11:21]

The header file is still in common_audio_c, and that target doesn't  depend on
this one.

I'd suggest moving dot_product_with_scale.cc to its own target, and give it its
own header file there. Then #include that header from
signal_processing_library.h, and add the required dep from common_audio_c on
your new target---or just add the #include to all callers directly, since
signal_processing_library.h isn't a public header?

[hlundin-webrtc, 2017/02/28 12:35:17]

Done.

     "smoothing_filter.cc",
     "smoothing_filter.h",
     "sparse_fir_filter.cc",
@@ -113,7 +114,6 @@ rtc_source_set("common_audio_c") {
     "signal_processing/copy_set_operations.c",
     "signal_processing/cross_correlation.c",
     "signal_processing/division_operations.c",
-    "signal_processing/dot_product_with_scale.c",
     "signal_processing/downsample_fast.c",
     "signal_processing/energy.c",
     "signal_processing/filter_ar.c",