Avoid overflow in WebRtcSpl_DotProductWithScale

webrtc/common_audio/BUILD.gn

 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("//build/config/arm.gni")
 import("../webrtc.gni")
@@ skipping 29 matching lines @@
     "real_fourier_ooura.cc",
     "real_fourier_ooura.h",
     "resampler/include/push_resampler.h",
     "resampler/include/resampler.h",
     "resampler/push_resampler.cc",
     "resampler/push_sinc_resampler.cc",
     "resampler/push_sinc_resampler.h",
     "resampler/resampler.cc",
     "resampler/sinc_resampler.cc",
     "resampler/sinc_resampler.h",
+    "signal_processing/dot_product_with_scale.cc",

[kwiberg-webrtc, 2017/02/28 12:11:21]

The header file is still in common_audio_c, and that target doesn't  depend on
this one.

I'd suggest moving dot_product_with_scale.cc to its own target, and give it its
own header file there. Then #include that header from
signal_processing_library.h, and add the required dep from common_audio_c on
your new target---or just add the #include to all callers directly, since
signal_processing_library.h isn't a public header?

[hlundin-webrtc, 2017/02/28 12:35:17]

Done.

     "smoothing_filter.cc",
     "smoothing_filter.h",
     "sparse_fir_filter.cc",
     "sparse_fir_filter.h",
     "vad/include/vad.h",
     "vad/vad.cc",
     "wav_file.cc",
     "wav_file.h",
     "wav_header.cc",
     "wav_header.h",
@@ skipping 46 matching lines @@
     "fft4g.c",
     "fft4g.h",
     "ring_buffer.c",
     "ring_buffer.h",
     "signal_processing/auto_corr_to_refl_coef.c",
     "signal_processing/auto_correlation.c",
     "signal_processing/complex_fft_tables.h",
     "signal_processing/copy_set_operations.c",
     "signal_processing/cross_correlation.c",
     "signal_processing/division_operations.c",
-    "signal_processing/dot_product_with_scale.c",
     "signal_processing/downsample_fast.c",
     "signal_processing/energy.c",
     "signal_processing/filter_ar.c",
     "signal_processing/filter_ma_fast_q12.c",
     "signal_processing/get_hanning_window.c",
     "signal_processing/get_scaling_square.c",
     "signal_processing/ilbc_specific_functions.c",
     "signal_processing/include/real_fft.h",
     "signal_processing/include/signal_processing_library.h",
     "signal_processing/include/spl_inl.h",
@@ skipping 213 matching lines @@
       "//testing/gtest",
     ]
 
     if (is_android) {
       deps += [ "//testing/android/native_test:native_test_support" ]
 
       shard_timeout = 900
     }
   }
 }