Avoid overflow in WebRtcSpl_DotProductWithScale

webrtc/common_audio/BUILD.gn

Index: webrtc/common_audio/BUILD.gn
diff --git a/webrtc/common_audio/BUILD.gn b/webrtc/common_audio/BUILD.gn
index 6162793a6d38b54711e976dc1b2c968fa55ab5d1..c71da2d2baaea709e8d9a1d24988736655c62445 100644
--- a/webrtc/common_audio/BUILD.gn
+++ b/webrtc/common_audio/BUILD.gn
@@ -116,7 +116,6 @@ rtc_source_set("common_audio_c") {
     "signal_processing/copy_set_operations.c",
     "signal_processing/cross_correlation.c",
     "signal_processing/division_operations.c",
-    "signal_processing/dot_product_with_scale.c",
     "signal_processing/downsample_fast.c",
     "signal_processing/energy.c",
     "signal_processing/filter_ar.c",
@@ -203,6 +202,26 @@ rtc_source_set("common_audio_c") {
 
   public_configs = [ ":common_audio_config" ]
   deps = [
+    ":common_audio_cc",
+    "..:webrtc_common",
+    "../base:rtc_base_approved",
+    "../system_wrappers:system_wrappers",
+  ]
+}
+
+rtc_source_set("common_audio_cc") {
+  visibility = [ ":*" ]  # Only targets in this file can depend on this.
+  sources = [
+    "signal_processing/dot_product_with_scale.cc",
+    "signal_processing/dot_product_with_scale.h",
+  ]
+
+  if (is_win) {
+    cflags = [ "/wd4334" ]  # Ignore warning on shift operator promotion.

[kwiberg-webrtc, 2017/03/07 10:27:21]

Ideally, you'd fix this warning instead since it's such a small amount of code,
but I guess it's OK to let it be for now.

[hlundin-webrtc, 2017/03/07 11:40:05]

Done.

[kwiberg-webrtc, 2017/03/07 11:54:51]

Aha, it was that easy!

+  }
+
+  public_configs = [ ":common_audio_config" ]
+  deps = [
     "..:webrtc_common",
     "../base:rtc_base_approved",
     "../system_wrappers:system_wrappers",