Avoid overflow in WebRtcSpl_DotProductWithScale

webrtc/common_audio/BUILD.gn

 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("//build/config/arm.gni")
 import("../webrtc.gni")
@@ skipping 98 matching lines @@
     "fft4g.c",
     "fft4g.h",
     "ring_buffer.c",
     "ring_buffer.h",
     "signal_processing/auto_corr_to_refl_coef.c",
     "signal_processing/auto_correlation.c",
     "signal_processing/complex_fft_tables.h",
     "signal_processing/copy_set_operations.c",
     "signal_processing/cross_correlation.c",
     "signal_processing/division_operations.c",
-    "signal_processing/dot_product_with_scale.c",
     "signal_processing/downsample_fast.c",
     "signal_processing/energy.c",
     "signal_processing/filter_ar.c",
     "signal_processing/filter_ma_fast_q12.c",
     "signal_processing/get_hanning_window.c",
     "signal_processing/get_scaling_square.c",
     "signal_processing/ilbc_specific_functions.c",
     "signal_processing/include/real_fft.h",
     "signal_processing/include/signal_processing_library.h",
     "signal_processing/include/spl_inl.h",
@@ skipping 66 matching lines @@
       "signal_processing/spl_sqrt_floor.c",
     ]
   }
 
   if (is_win) {
     cflags = [ "/wd4334" ]  # Ignore warning on shift operator promotion.
   }
 
   public_configs = [ ":common_audio_config" ]
   deps = [
+    ":common_audio_cc",
+    "..:webrtc_common",
+    "../base:rtc_base_approved",
+    "../system_wrappers:system_wrappers",
+  ]
+}
+
+rtc_source_set("common_audio_cc") {
+  visibility = [ ":*" ]  # Only targets in this file can depend on this.
+  sources = [
+    "signal_processing/dot_product_with_scale.cc",
+    "signal_processing/dot_product_with_scale.h",
+  ]
+
+  if (is_win) {
+    cflags = [ "/wd4334" ]  # Ignore warning on shift operator promotion.

[kwiberg-webrtc, 2017/03/07 10:27:21]

Ideally, you'd fix this warning instead since it's such a small amount of code,
but I guess it's OK to let it be for now.

[hlundin-webrtc, 2017/03/07 11:40:05]

Done.

[kwiberg-webrtc, 2017/03/07 11:54:51]

Aha, it was that easy!

+  }
+
+  public_configs = [ ":common_audio_config" ]
+  deps = [
     "..:webrtc_common",
     "../base:rtc_base_approved",
     "../system_wrappers:system_wrappers",
   ]
 }
 
 rtc_source_set("sinc_resampler") {
   sources = [
     "resampler/sinc_resampler.h",
   ]
@@ skipping 171 matching lines @@
       "//testing/gtest",
     ]
 
     if (is_android) {
       deps += [ "//testing/android/native_test:native_test_support" ]
 
       shard_timeout = 900
     }
   }
 }