Split FlexFEC field trial in two.

Split FlexFEC field trial in two.

- The "flexfec-03" codec is advertised in the SDP whenever the
  "WebRTC-FlexFEC-03-Advertised" field trial is enabled.
- Sending FlexFEC packets is enabled whenever the "flexfec-03" codec is
  negotiated, and the "WebRTC-FlexFEC-03" field trial is enabled.

After this CL, the number of calls to
WebRtcVideoChannel2::WebRtcVideoSendStream::SetCodec during renegotiation
will be reduced for cases when only one endpoint has the "WebRTC-FlexFEC-03"
field trial enabled.

BUG=webrtc:5654
Review-Url: https://codereview.webrtc.org/2716733005
Cr-Commit-Position: refs/heads/master@{#16925}
Committed: https://chromium.googlesource.com/external/webrtc/+/340e3fd59f2af4b13e5ffb8430cf87e15f334066

[brandtr, 2017-02-27 23:48:29]

Update.

[brandtr, 2017-02-28 00:40:11]

objc

[brandtr, 2017-02-28 00:44:34]

Patchset #1 (id:1) has been deleted

[brandtr, 2017-02-28 00:44:39]

Patchset #1 (id:20001) has been deleted

[brandtr, 2017-02-28 00:46:59]

Description was changed from

==========
Split FlexFEC field trial in two.

- The "flexfec-03" codec is advertised and negotiated in the SDP whenever
  the "WebRTC-FlexFEC-03-Advertised" field trial is enabled.
- Sending FlexFEC packets is enabled whenever the "flexfec-03" codec is
  negotiated, and the "WebRTC-FlexFEC-03" field trial is enabled.

After this CL, the number of calls to
WebRtcVideoChannel2::WebRtcVideoSendStream::SetCodec during renegotiation
will be reduced for cases when only one endpoint has the
"WebRTC-FlexFEC-03" field trial enabled.

BUG=webrtc:5654
==========

to

==========
Split FlexFEC field trial in two.

- The "flexfec-03" codec is advertised in the SDP whenever the
  "WebRTC-FlexFEC-03-Advertised" field trial is enabled.
- Sending FlexFEC packets is enabled whenever the "flexfec-03" codec is
  negotiated, and the "WebRTC-FlexFEC-03" field trial is enabled.

After this CL, the number of calls to
WebRtcVideoChannel2::WebRtcVideoSendStream::SetCodec during renegotiation
will be reduced for cases when only one endpoint has the "WebRTC-FlexFEC-03"
field trial enabled.

BUG=webrtc:5654
==========

[brandtr, 2017-02-28 00:52:50]

Patchset #1 (id:40001) has been deleted

[brandtr, 2017-02-28 17:08:00]

Patchset #1 (id:60001) has been deleted

[brandtr, 2017-02-28 17:31:48]

Rebase.

[brandtr, 2017-02-28 17:32:11]

Patchset #1 (id:80001) has been deleted

[brandtr, 2017-02-28 17:50:32]

brandtr@webrtc.org changed reviewers:
+ stefan@webrtc.org, tkchin@webrtc.org

[brandtr, 2017-02-28 17:50:33]

As discussed yesterday.

https://codereview.webrtc.org/2716733005/diff/100001/webrtc/media/engine/webr...
File webrtc/media/engine/webrtcvideoengine2.cc (left):

https://codereview.webrtc.org/2716733005/diff/100001/webrtc/media/engine/webr...
webrtc/media/engine/webrtcvideoengine2.cc:2298: if (IsFlexfecFieldTrialEnabled()
&& flexfec_config_.IsCompleteAndEnabled()) {
Our ability on receiving FlexFEC packets should no longer be contingent on
whether or not the "WebRTC-FlexFEC-03" field trial is enabled or not.

https://codereview.webrtc.org/2716733005/diff/100001/webrtc/media/engine/webr...
File webrtc/media/engine/webrtcvideoengine2.cc (right):

https://codereview.webrtc.org/2716733005/diff/100001/webrtc/media/engine/webr...
webrtc/media/engine/webrtcvideoengine2.cc:1713: if
(IsFlexfecFieldTrialEnabled()) {
This check is not strictly necessary, but without it the FlexFEC config in
VideoSendStream::Config would be partially populated, even when the
"WebRTC-FlexFEC-03" field trial is not enabled.

[tkchin_webrtc, 2017-02-28 18:41:05]

On 2017/02/28 17:50:33, brandtr wrote:
> As discussed yesterday.
> 
>
https://codereview.webrtc.org/2716733005/diff/100001/webrtc/media/engine/webr...
> File webrtc/media/engine/webrtcvideoengine2.cc (left):
> 
>
https://codereview.webrtc.org/2716733005/diff/100001/webrtc/media/engine/webr...
> webrtc/media/engine/webrtcvideoengine2.cc:2298: if
(IsFlexfecFieldTrialEnabled()
> && flexfec_config_.IsCompleteAndEnabled()) {
> Our ability on receiving FlexFEC packets should no longer be contingent on
> whether or not the "WebRTC-FlexFEC-03" field trial is enabled or not.
> 
>
https://codereview.webrtc.org/2716733005/diff/100001/webrtc/media/engine/webr...
> File webrtc/media/engine/webrtcvideoengine2.cc (right):
> 
>
https://codereview.webrtc.org/2716733005/diff/100001/webrtc/media/engine/webr...
> webrtc/media/engine/webrtcvideoengine2.cc:1713: if
> (IsFlexfecFieldTrialEnabled()) {
> This check is not strictly necessary, but without it the FlexFEC config in
> VideoSendStream::Config would be partially populated, even when the
> "WebRTC-FlexFEC-03" field trial is not enabled.

objc lgtm

[stefan-webrtc, 2017-02-28 19:06:46]

lgtm

[brandtr, 2017-02-28 23:06:29]

The CQ bit was checked by brandtr@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 23:06:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-28 23:27:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 23:27:47]

Dry run: This issue passed the CQ dry run.

[brandtr, 2017-02-28 23:40:29]

The CQ bit was checked by brandtr@webrtc.org

[commit-bot: I haz the power, 2017-02-28 23:40:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-28 23:43:11]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1488325229274190,
"parent_rev": "28922448012e39f33124bb112e54faecc454dea6", "commit_rev":
"340e3fd59f2af4b13e5ffb8430cf87e15f334066"}

[commit-bot: I haz the power, 2017-02-28 23:43:14]

Description was changed from

==========
Split FlexFEC field trial in two.

- The "flexfec-03" codec is advertised in the SDP whenever the
  "WebRTC-FlexFEC-03-Advertised" field trial is enabled.
- Sending FlexFEC packets is enabled whenever the "flexfec-03" codec is
  negotiated, and the "WebRTC-FlexFEC-03" field trial is enabled.

After this CL, the number of calls to
WebRtcVideoChannel2::WebRtcVideoSendStream::SetCodec during renegotiation
will be reduced for cases when only one endpoint has the "WebRTC-FlexFEC-03"
field trial enabled.

BUG=webrtc:5654
==========

to

==========
Split FlexFEC field trial in two.

- The "flexfec-03" codec is advertised in the SDP whenever the
  "WebRTC-FlexFEC-03-Advertised" field trial is enabled.
- Sending FlexFEC packets is enabled whenever the "flexfec-03" codec is
  negotiated, and the "WebRTC-FlexFEC-03" field trial is enabled.

After this CL, the number of calls to
WebRtcVideoChannel2::WebRtcVideoSendStream::SetCodec during renegotiation
will be reduced for cases when only one endpoint has the "WebRTC-FlexFEC-03"
field trial enabled.

BUG=webrtc:5654

Review-Url: https://codereview.webrtc.org/2716733005
Cr-Commit-Position: refs/heads/master@{#16925}
Committed:
https://chromium.googlesource.com/external/webrtc/+/340e3fd59f2af4b13e5ffb843...
==========

[commit-bot: I haz the power, 2017-02-28 23:43:15]

Committed patchset #1 (id:100001) as
https://chromium.googlesource.com/external/webrtc/+/340e3fd59f2af4b13e5ffb843...