vh units shouldn't add controls height when controls are locked to hidden.

vh units shouldn't add controls height when controls are locked to hidden.

Since the initial containing block is now fixed to be the size as if the
browser controls are always shown -- and we want 100vh to appear as if the
viewport is always hidden -- we add the browser controls height to the layout
height used for viewport units.

One exception to this when the browser controls are locked in a hidden state.
In that case, the ICB is actually set to fill the full viewport. In that case
adding the controls height actually makes 100vh taller than the viewport. This
patch avoids adding the controls height when controls are locked hidden.

BUG=688738
Review-Url: https://codereview.chromium.org/2716453004
Cr-Commit-Position: refs/heads/master@{#452991}
Committed: https://chromium.googlesource.com/chromium/src/+/85fff922d53f16ad66d8d39cb066cbcda1640052

[bokan, 2017-02-24 19:41:58]

The CQ bit was checked by bokan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 19:42:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 21:09:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 21:09:23]

Dry run: This issue passed the CQ dry run.

[bokan, 2017-02-24 21:11:23]

Description was changed from

==========
vh units shouldn't add controls height when controls are locked to hidden.

Since the initial containing block is now fixed to be the size as if the
browser controls are always shown -- and we want 100vh to appear as if the
viewport is always hidden -- we add the browser controls height to the layout
height used for viewport units.

One exception to this when the browser controls are locked in a hidden state.
In that case, the ICB is actually set to fill the full viewport. In that case
adding the controls height actually makes 100vh taller than the viewport. This
patch avoids adding the controls height when controls are locked hidden.

BUG=688738
==========

to

==========
vh units shouldn't add controls height when controls are locked to hidden.

Since the initial containing block is now fixed to be the size as if the
browser controls are always shown -- and we want 100vh to appear as if the
viewport is always hidden -- we add the browser controls height to the layout
height used for viewport units.

One exception to this when the browser controls are locked in a hidden state.
In that case, the ICB is actually set to fill the full viewport. In that case
adding the controls height actually makes 100vh taller than the viewport. This
patch avoids adding the controls height when controls are locked hidden.

BUG=688738
==========

[bokan, 2017-02-24 21:11:23]

bokan@chromium.org changed reviewers:
+ aelias@chromium.org

[bokan, 2017-02-24 21:15:29]

Hey Alexandre,

This fixes vh units in fullscreen modes where controls are locked hidden.

I tried making it so 100vh also uses the ICB when controls are locked shown but
we lock the controls to shown while a page loads so we'd have a jarring relayout
on every page when the unlocking happens. (I actually couldn't even get the
relayout to work though).

Given that I don't know of any scenarios where we lock the controls
non-transiently, this feels good to me. PTAL

[aelias_OOO_until_Jul13, 2017-02-24 21:36:15]

lgtm

[bokan, 2017-02-24 21:36:38]

The CQ bit was checked by bokan@chromium.org

[commit-bot: I haz the power, 2017-02-24 21:37:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 23:25:31]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487972198431930,
"parent_rev": "19e1e20024109653910be72bd7ccbcc866a47c26", "commit_rev":
"85fff922d53f16ad66d8d39cb066cbcda1640052"}

[commit-bot: I haz the power, 2017-02-24 23:26:09]

Description was changed from

==========
vh units shouldn't add controls height when controls are locked to hidden.

Since the initial containing block is now fixed to be the size as if the
browser controls are always shown -- and we want 100vh to appear as if the
viewport is always hidden -- we add the browser controls height to the layout
height used for viewport units.

One exception to this when the browser controls are locked in a hidden state.
In that case, the ICB is actually set to fill the full viewport. In that case
adding the controls height actually makes 100vh taller than the viewport. This
patch avoids adding the controls height when controls are locked hidden.

BUG=688738
==========

to

==========
vh units shouldn't add controls height when controls are locked to hidden.

Since the initial containing block is now fixed to be the size as if the
browser controls are always shown -- and we want 100vh to appear as if the
viewport is always hidden -- we add the browser controls height to the layout
height used for viewport units.

One exception to this when the browser controls are locked in a hidden state.
In that case, the ICB is actually set to fill the full viewport. In that case
adding the controls height actually makes 100vh taller than the viewport. This
patch avoids adding the controls height when controls are locked hidden.

BUG=688738

Review-Url: https://codereview.chromium.org/2716453004
Cr-Commit-Position: refs/heads/master@{#452991}
Committed:
https://chromium.googlesource.com/chromium/src/+/85fff922d53f16ad66d8d39cb066...
==========

[commit-bot: I haz the power, 2017-02-24 23:26:18]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/85fff922d53f16ad66d8d39cb066...