Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2716413004: Restructure protobuf targets to fit with downstream requirements. (Closed)

Created:
3 years, 9 months ago by kjellander_webrtc
Modified:
3 years, 9 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, Andrew MacDonald, aleloi, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Restructure protobuf targets to fit with downstream requirements. The paths of the protobuf output files needs to match the actual tree path in order for Bazel builds to work. BUG=webrtc:6412 NOTRY=True Review-Url: https://codereview.webrtc.org/2716413004 Cr-Commit-Position: refs/heads/master@{#16912} Committed: https://chromium.googlesource.com/external/webrtc/+/e3e902eef9dcf94342336cd982076fe69df2db4b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M webrtc/modules/audio_coding/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/audio_processing_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
kjellander_webrtc
3 years, 9 months ago (2017-02-28 07:34:57 UTC) #3
hlundin-webrtc
lgtm
3 years, 9 months ago (2017-02-28 09:25:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2716413004/1
3 years, 9 months ago (2017-02-28 15:59:28 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 16:01:50 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/e3e902eef9dcf94342336cd98...

Powered by Google App Engine
This is Rietveld 408576698