Enable GN check for webrtc/media

Enable GN check for webrtc/media

BUG=webrtc:6828, webrtc:7245
NOTRY=True

Review-Url: https://codereview.webrtc.org/2716143002
Cr-Commit-Position: refs/heads/master@{#17067}
Committed: https://chromium.googlesource.com/external/webrtc/+/a2ef4f94e478ac1eb8b3be47e63cdcd56cf66207

[kjellander_webrtc, 2017-03-03 04:41:24]

Description was changed from

==========
Enable GN check for webrtc/media

BUG=webrtc:6828
==========

to

==========
Enable GN check for webrtc/media

BUG=webrtc:6828, webrtc:7245
==========

[kjellander_webrtc, 2017-03-03 04:41:24]

kjellander@webrtc.org changed reviewers:
+ magjed@webrtc.org

[magjed_webrtc, 2017-03-03 11:58:16]

https://codereview.webrtc.org/2716143002/diff/20001/webrtc/media/BUILD.gn
File webrtc/media/BUILD.gn (right):

https://codereview.webrtc.org/2716143002/diff/20001/webrtc/media/BUILD.gn#new...
webrtc/media/BUILD.gn:224: "../api:video_frame_api",
How did you generate all these deps? It's difficult to verify.

[kjellander_webrtc, 2017-03-03 19:38:42]

https://codereview.webrtc.org/2716143002/diff/20001/webrtc/media/BUILD.gn
File webrtc/media/BUILD.gn (right):

https://codereview.webrtc.org/2716143002/diff/20001/webrtc/media/BUILD.gn#new...
webrtc/media/BUILD.gn:224: "../api:video_frame_api",
On 2017/03/03 11:58:16, magjed_webrtc wrote:
> How did you generate all these deps? It's difficult to verify.

They all come from the complaints of 'gn check' (or 'gn gen out/blah --check').
But then Edward wrote a tool that can be used to avoid most of the manual
labour: tools-webrtc/gn_check_autofix.py.
Example use: python tools-webrtc/gn_check_autofix.py -m "client.webrtc" -b
"Linux64 Debug"

Try patching this CL, remove one of these lines and run 'gn check'. Then you'll
see what source file is having an include that introduces the dependency.

[magjed_webrtc, 2017-03-06 10:11:59]

lgtm

https://codereview.webrtc.org/2716143002/diff/20001/webrtc/media/BUILD.gn
File webrtc/media/BUILD.gn (right):

https://codereview.webrtc.org/2716143002/diff/20001/webrtc/media/BUILD.gn#new...
webrtc/media/BUILD.gn:224: "../api:video_frame_api",
On 2017/03/03 19:38:42, kjellander_webrtc wrote:
> On 2017/03/03 11:58:16, magjed_webrtc wrote:
> > How did you generate all these deps? It's difficult to verify.
> 
> They all come from the complaints of 'gn check' (or 'gn gen out/blah
--check').
> But then Edward wrote a tool that can be used to avoid most of the manual
> labour: tools-webrtc/gn_check_autofix.py.
> Example use: python tools-webrtc/gn_check_autofix.py -m "client.webrtc" -b
> "Linux64 Debug"
> 
> Try patching this CL, remove one of these lines and run 'gn check'. Then
you'll
> see what source file is having an include that introduces the dependency.

Cool! Very useful.

[kjellander_webrtc, 2017-03-06 13:41:54]

Description was changed from

==========
Enable GN check for webrtc/media

BUG=webrtc:6828, webrtc:7245
==========

to

==========
Enable GN check for webrtc/media

BUG=webrtc:6828, webrtc:7245
NOTRY=True
==========

[kjellander_webrtc, 2017-03-06 14:02:28]

The CQ bit was checked by kjellander@webrtc.org

[kjellander_webrtc, 2017-03-06 14:02:29]

The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2716143002/#ps60001 (title:
"Restore .gn")

[commit-bot: I haz the power, 2017-03-06 14:02:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-06 14:04:56]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488808948838190,
"parent_rev": "f94900083484c53bc9717c66794f0b74f5e4f471", "commit_rev":
"a2ef4f94e478ac1eb8b3be47e63cdcd56cf66207"}

[commit-bot: I haz the power, 2017-03-06 14:04:58]

Description was changed from

==========
Enable GN check for webrtc/media

BUG=webrtc:6828, webrtc:7245
NOTRY=True
==========

to

==========
Enable GN check for webrtc/media

BUG=webrtc:6828, webrtc:7245
NOTRY=True

Review-Url: https://codereview.webrtc.org/2716143002
Cr-Commit-Position: refs/heads/master@{#17067}
Committed:
https://chromium.googlesource.com/external/webrtc/+/a2ef4f94e478ac1eb8b3be47e...
==========

[commit-bot: I haz the power, 2017-03-06 14:05:00]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/a2ef4f94e478ac1eb8b3be47e...