Add PESQ precompiled tool for audio quality testing

Add PESQ precompiled tool for audio quality testing

BUG=webrtc:7229
Review-Url: https://codereview.webrtc.org/2715933003
Cr-Commit-Position: refs/heads/master@{#17055}
Committed: https://chromium.googlesource.com/external/webrtc/+/3b2fb203fd11eeccc9039c3381ea443848cc6198

[oprypin_webrtc, 2017-02-24 15:50:46]

Description was changed from

==========
Add PESQ precompiled tool for audio quality testing

BUG=webrtc:7229
==========

to

==========
Add PESQ precompiled tool for audio quality testing

BUG=webrtc:7229
==========

[oprypin_webrtc, 2017-02-24 15:50:47]

oprypin@webrtc.org changed reviewers:
+ kjellander@google.com

[oprypin_webrtc, 2017-02-24 15:51:18]

oprypin@webrtc.org changed reviewers:
+ kjellander@webrtc.org
- kjellander@google.com

[kjellander_webrtc, 2017-02-27 07:05:13]

https://codereview.webrtc.org/2715933003/diff/1/tools-webrtc/audio_quality/RE...
File tools-webrtc/audio_quality/README (right):

https://codereview.webrtc.org/2715933003/diff/1/tools-webrtc/audio_quality/RE...
tools-webrtc/audio_quality/README:2: which is a google-internal bucket. If
you're a non-Googler you'll have to download
nit: move "download" to line 3

https://codereview.webrtc.org/2715933003/diff/1/tools-webrtc/download.py
File tools-webrtc/download.py (right):

https://codereview.webrtc.org/2715933003/diff/1/tools-webrtc/download.py#newc...
tools-webrtc/download.py:32: path,
Skip the directory handling in main() + the loop above and pass in SCRIPT_DIR
here instead. Since it's using --recursive it should find the files in both
audio_quality and video_quality_toolchain.

In case we'll need the script to be able to download publicly available
resources in the future, we can deal with that now (and those can likely go into
the resources/ dir anyway).

https://codereview.webrtc.org/2715933003/diff/1/webrtc/examples/androidtests/...
File webrtc/examples/androidtests/video_quality_loopback_test.py (right):

https://codereview.webrtc.org/2715933003/diff/1/webrtc/examples/androidtests/...
webrtc/examples/androidtests/video_quality_loopback_test.py:81:
_RunCommand([sys.executable, download_script, toolchain_dir])
Then you'll just skip this argument too.

[oprypin_webrtc, 2017-03-02 17:30:08]

https://codereview.webrtc.org/2715933003/diff/1/tools-webrtc/audio_quality/RE...
File tools-webrtc/audio_quality/README (right):

https://codereview.webrtc.org/2715933003/diff/1/tools-webrtc/audio_quality/RE...
tools-webrtc/audio_quality/README:2: which is a google-internal bucket. If
you're a non-Googler you'll have to download
On 2017/02/27 07:05:13, kjellander_webrtc wrote:
> nit: move "download" to line 3

Done.

https://codereview.webrtc.org/2715933003/diff/1/tools-webrtc/download.py
File tools-webrtc/download.py (right):

https://codereview.webrtc.org/2715933003/diff/1/tools-webrtc/download.py#newc...
tools-webrtc/download.py:32: path,
On 2017/02/27 07:05:13, kjellander_webrtc wrote:
> Skip the directory handling in main() + the loop above and pass in SCRIPT_DIR
> here instead. Since it's using --recursive it should find the files in both
> audio_quality and video_quality_toolchain.
> 
> In case we'll need the script to be able to download publicly available
> resources in the future, we can deal with that now (and those can likely go
into
> the resources/ dir anyway).

This is done so each test can specify what subdirectory to download when
executing this script, to skip unnecessary downloads. I think it adds
flexibility with very little overhead.
Keeping as is, but can change it if you insist.

[kjellander_webrtc, 2017-03-03 04:33:56]

https://codereview.webrtc.org/2715933003/diff/1/tools-webrtc/download.py
File tools-webrtc/download.py (right):

https://codereview.webrtc.org/2715933003/diff/1/tools-webrtc/download.py#newc...
tools-webrtc/download.py:10: """Downloads precompiled tools."""
Since this script is now more visible in the new location, it should have a
comment that explains why non-Googlers that try to run this will get an error.
See
https://chromium.googlesource.com/external/webrtc/+/master/tools-webrtc/video...
for inspiration.

https://codereview.webrtc.org/2715933003/diff/1/tools-webrtc/download.py#newc...
tools-webrtc/download.py:32: path,
On 2017/03/02 17:30:08, oprypin_webrtc wrote:
> On 2017/02/27 07:05:13, kjellander_webrtc wrote:
> > Skip the directory handling in main() + the loop above and pass in
SCRIPT_DIR
> > here instead. Since it's using --recursive it should find the files in both
> > audio_quality and video_quality_toolchain.
> > 
> > In case we'll need the script to be able to download publicly available
> > resources in the future, we can deal with that now (and those can likely go
> into
> > the resources/ dir anyway).
> 
> This is done so each test can specify what subdirectory to download when
> executing this script, to skip unnecessary downloads. I think it adds
> flexibility with very little overhead.
> Keeping as is, but can change it if you insist.

Sure, that could be a useful feature as it works both if you specify a dir and
not. 
But you're going to have to update
https://chromium.googlesource.com/external/webrtc/+/master/webrtc/examples/an...
then, so it calls the right script.

Also, since it's now located in tools-webrtc, I think download.py is suddenly a
too generic name. I suggest renaming to download_resources.py.

[oprypin_webrtc, 2017-03-03 19:24:50]

https://codereview.webrtc.org/2715933003/diff/1/tools-webrtc/download.py
File tools-webrtc/download.py (right):

https://codereview.webrtc.org/2715933003/diff/1/tools-webrtc/download.py#newc...
tools-webrtc/download.py:10: """Downloads precompiled tools."""
On 2017/03/03 04:33:56, kjellander_webrtc wrote:
> Since this script is now more visible in the new location, it should have a
> comment that explains why non-Googlers that try to run this will get an error.
> See
>
https://chromium.googlesource.com/external/webrtc/+/master/tools-webrtc/video...
> for inspiration.

Done.

https://codereview.webrtc.org/2715933003/diff/1/tools-webrtc/download.py#newc...
tools-webrtc/download.py:32: path,
On 2017/03/03 04:33:56, kjellander_webrtc wrote:
> On 2017/03/02 17:30:08, oprypin_webrtc wrote:
> > On 2017/02/27 07:05:13, kjellander_webrtc wrote:
> > > Skip the directory handling in main() + the loop above and pass in
> SCRIPT_DIR
> > > here instead. Since it's using --recursive it should find the files in
both
> > > audio_quality and video_quality_toolchain.
> > > 
> > > In case we'll need the script to be able to download publicly available
> > > resources in the future, we can deal with that now (and those can likely
go
> > into
> > > the resources/ dir anyway).
> > 
> > This is done so each test can specify what subdirectory to download when
> > executing this script, to skip unnecessary downloads. I think it adds
> > flexibility with very little overhead.
> > Keeping as is, but can change it if you insist.
> 
> Sure, that could be a useful feature as it works both if you specify a dir and
> not. 
> But you're going to have to update
>
https://chromium.googlesource.com/external/webrtc/+/master/webrtc/examples/an...
> then, so it calls the right script.
> 
> Also, since it's now located in tools-webrtc, I think download.py is suddenly
a
> too generic name. I suggest renaming to download_resources.py.
> 

Done.

[oprypin_webrtc, 2017-03-03 19:30:09]

Patchset #4 (id:60001) has been deleted

[oprypin_webrtc, 2017-03-03 19:30:36]

Patchset #3 (id:40001) has been deleted

[kjellander_webrtc, 2017-03-03 19:33:33]

lgtm

[oprypin_webrtc, 2017-03-05 15:13:17]

The CQ bit was checked by oprypin@webrtc.org

[commit-bot: I haz the power, 2017-03-05 15:13:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-05 15:17:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-05 15:17:58]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/14499)

[oprypin_webrtc, 2017-03-06 09:36:48]

oprypin@webrtc.org changed reviewers:
+ magjed@webrtc.org

[oprypin_webrtc, 2017-03-06 09:37:43]

Added magjed@webrtc.org to review
webrtc/examples/androidtests/video_quality_loopback_test.py

[magjed_webrtc, 2017-03-06 10:14:16]

webrtc/examples/androidtests/video_quality_loopback_test.py lgtm

[oprypin_webrtc, 2017-03-06 10:21:14]

The CQ bit was checked by oprypin@webrtc.org

[commit-bot: I haz the power, 2017-03-06 10:21:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-06 10:23:34]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1488795674601810,
"parent_rev": "518161bde59b8f795448321531b009f591a8748d", "commit_rev":
"3b2fb203fd11eeccc9039c3381ea443848cc6198"}

[commit-bot: I haz the power, 2017-03-06 10:23:38]

Description was changed from

==========
Add PESQ precompiled tool for audio quality testing

BUG=webrtc:7229
==========

to

==========
Add PESQ precompiled tool for audio quality testing

BUG=webrtc:7229

Review-Url: https://codereview.webrtc.org/2715933003
Cr-Commit-Position: refs/heads/master@{#17055}
Committed:
https://chromium.googlesource.com/external/webrtc/+/3b2fb203fd11eeccc9039c338...
==========

[commit-bot: I haz the power, 2017-03-06 10:23:40]

Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/external/webrtc/+/3b2fb203fd11eeccc9039c338...