Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2715433002: Selection API: deleteFromDocument() should not call setBaseAndExtent(). (Closed)

Created:
3 years, 10 months ago by tkent
Modified:
3 years, 10 months ago
Reviewers:
yoichio, yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Selection API: deleteFromDocument() should not call setBaseAndExtent(). deleteFromDocument() called setBaseAndExtent() with non-adjusted points. We don't need to call setBaseAndExtent() there. The draft doesn't define such behavior. https://www.w3.org/TR/selection-api/#dom-selection-deletefromdocument BUG=693955 Review-Url: https://codereview.chromium.org/2715433002 Cr-Commit-Position: refs/heads/master@{#451981} Committed: https://chromium.googlesource.com/chromium/src/+/25ca749f44e7a1f8955f51fb30ed4e0a6287496c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -5 lines) Patch
A third_party/WebKit/LayoutTests/editing/selection/deletefromdocument-shadow-leak.html View 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/DOMSelection.cpp View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
tkent
yoichio@, yosin@, would you review this please?
3 years, 10 months ago (2017-02-22 09:12:11 UTC) #7
yosin_UTC9
lgtm
3 years, 10 months ago (2017-02-22 09:30:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715433002/1
3 years, 10 months ago (2017-02-22 09:33:24 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 10:41:50 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/25ca749f44e7a1f8955f51fb30ed...

Powered by Google App Engine
This is Rietveld 408576698