Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Issue 2715363003: Minor correction to the help printout, to reflect the current behaviour. (Closed)

Created:
3 years, 9 months ago by VladimirTechMan
Modified:
3 years, 9 months ago
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Minor correction to the help printout, to reflect the actual behaviour Just a small update to the embedded description of the script outcome, to match the actual situation, after a quick sync-up at: https://codereview.webrtc.org/2712263002/ NOTRY=True BUG=None Review-Url: https://codereview.webrtc.org/2715363003 Cr-Commit-Position: refs/heads/master@{#16947} Committed: https://chromium.googlesource.com/external/webrtc/+/4cbe2862524d8e2cb31d0715eb1d26b378846417

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M tools-webrtc/ios/build_ios_libs.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
VladimirTechMan
3 years, 9 months ago (2017-02-28 17:44:04 UTC) #3
kthelgason
Thanks for this! lgtm.
3 years, 9 months ago (2017-03-01 07:45:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2715363003/1
3 years, 9 months ago (2017-03-01 07:45:54 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/14298)
3 years, 9 months ago (2017-03-01 07:50:07 UTC) #8
kthelgason
We're going to need kjellander@ to sign off on this as well, I don't own ...
3 years, 9 months ago (2017-03-01 07:52:41 UTC) #10
kjellander_webrtc
lgtm
3 years, 9 months ago (2017-03-01 15:06:26 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2715363003/1
3 years, 9 months ago (2017-03-01 15:06:38 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 15:08:36 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/4cbe2862524d8e2cb31d0715e...

Powered by Google App Engine
This is Rietveld 408576698