Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 2715113002: Enable GN check for webrtc/common_video (Closed)

Created:
3 years, 10 months ago by kjellander_webrtc
Modified:
3 years, 9 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Enable GN check for webrtc/common_video BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2715113002 Cr-Commit-Position: refs/heads/master@{#16883} Committed: https://chromium.googlesource.com/external/webrtc/+/1c6cc9a05f4f66bd24b8f2aabf87a78deee47682

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M .gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/common_video/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
kjellander_webrtc
3 years, 10 months ago (2017-02-26 06:58:08 UTC) #3
magjed_webrtc
lgtm
3 years, 9 months ago (2017-02-27 10:23:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2715113002/20001
3 years, 9 months ago (2017-02-28 00:35:19 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 00:37:58 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/1c6cc9a05f4f66bd24b8f2aab...

Powered by Google App Engine
This is Rietveld 408576698