Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1201)

Issue 2715103002: Replace NULL with nullptr or null in webrtc/api/. (Closed)

Created:
3 years, 10 months ago by Taylor Brandstetter
Modified:
3 years, 9 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace NULL with nullptr or null in webrtc/api/. BUG=webrtc:7147 Review-Url: https://codereview.webrtc.org/2715103002 Cr-Commit-Position: refs/heads/master@{#16880} Committed: https://chromium.googlesource.com/external/webrtc/+/8d60a946ae31acb52437159d01c38333c917bfb9

Patch Set 1 #

Patch Set 2 : merge with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -16 lines) Patch
M webrtc/api/jsep.h View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/api/jsepicecandidate.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/jsepsessiondescription.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/mediastreaminterface.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/notifier.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/peerconnectioninterface.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M webrtc/api/proxy.h View 1 2 chunks +5 lines, -2 lines 0 comments Download
M webrtc/api/statstypes.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/statstypes.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (11 generated)
Taylor Brandstetter
3 years, 10 months ago (2017-02-26 01:19:36 UTC) #2
pthatcher1
lgtm
3 years, 9 months ago (2017-02-27 17:49:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2715103002/20001
3 years, 9 months ago (2017-02-27 22:09:47 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios64_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios9_dbg/builds/1937)
3 years, 9 months ago (2017-02-27 22:27:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2715103002/20001
3 years, 9 months ago (2017-02-27 22:41:37 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 22:47:38 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/8d60a946ae31acb52437159d0...

Powered by Google App Engine
This is Rietveld 408576698