Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2714353002: Enable GN check in voice_engine/ (Closed)

Created:
3 years, 9 months ago by kjellander_webrtc
Modified:
3 years, 9 months ago
Reviewers:
the sun
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, henrika_webrtc, hlundin-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, peah-webrtc, minyue-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Enable GN check in voice_engine/ BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2714353002 Cr-Commit-Position: refs/heads/master@{#16986} Committed: https://chromium.googlesource.com/external/webrtc/+/cfa95aa99559ffa9bb48ddc5d7867f238310b1e1

Patch Set 1 #

Patch Set 2 : Fix #

Patch Set 3 : Add dep on //webrtc/modules/video_capture:video_capture #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M .gn View 1 1 chunk +1 line, -5 lines 0 comments Download
M webrtc/voice_engine/BUILD.gn View 1 2 6 chunks +16 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
the sun
On 2017/02/26 07:02:32, kjellander_webrtc wrote: > mailto:kjellander@webrtc.org changed reviewers: > + mailto:solenberg@webrtc.org I am holding ...
3 years, 9 months ago (2017-03-02 20:14:46 UTC) #3
kjellander_webrtc
On 2017/03/02 20:14:46, the sun wrote: > On 2017/02/26 07:02:32, kjellander_webrtc wrote: > > mailto:kjellander@webrtc.org ...
3 years, 9 months ago (2017-03-03 04:12:24 UTC) #4
the sun
On 2017/03/03 04:12:24, kjellander_webrtc wrote: > On 2017/03/02 20:14:46, the sun wrote: > > On ...
3 years, 9 months ago (2017-03-03 05:22:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2714353002/40001
3 years, 9 months ago (2017-03-03 05:26:08 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 05:28:27 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/cfa95aa99559ffa9bb48ddc5d...

Powered by Google App Engine
This is Rietveld 408576698