Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 2714153004: Enable MediaFoundationH264Encoding by default (Closed)

Created:
3 years, 10 months ago by emircan
Modified:
3 years, 10 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable MediaFoundationH264Encoding by default This CL enables this feature by default after the finch experiment. BUG=631783 Review-Url: https://codereview.chromium.org/2714153004 Cr-Commit-Position: refs/heads/master@{#452948} Committed: https://chromium.googlesource.com/chromium/src/+/2f52fcb3a305091ded42e8fe8ed5a0c0efe03013

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/base/media_switches.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (10 generated)
emircan
PTAL.
3 years, 10 months ago (2017-02-24 18:46:04 UTC) #5
rkaplow
lgtm lgtm but probably should be reviewed by someone on the feature team. Don't forget ...
3 years, 10 months ago (2017-02-24 18:59:00 UTC) #6
emircan
On 2017/02/24 18:59:00, rkaplow (slow) wrote: > lgtm > > lgtm but probably should be ...
3 years, 10 months ago (2017-02-24 21:09:33 UTC) #9
sdoyon
LGTM -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" ...
3 years, 10 months ago (2017-02-24 21:26:11 UTC) #10
emircan
Thanks. sandersd@ RS review please?
3 years, 10 months ago (2017-02-24 21:35:40 UTC) #12
sandersd (OOO until July 31)
lgtm
3 years, 10 months ago (2017-02-24 21:58:13 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2714153004/1
3 years, 10 months ago (2017-02-24 22:12:16 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 22:18:20 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2f52fcb3a305091ded42e8fe8ed5...

Powered by Google App Engine
This is Rietveld 408576698