|
|
DescriptionEnable MediaFoundationH264Encoding by default
This CL enables this feature by default after the finch experiment.
BUG=631783
Review-Url: https://codereview.chromium.org/2714153004
Cr-Commit-Position: refs/heads/master@{#452948}
Committed: https://chromium.googlesource.com/chromium/src/+/2f52fcb3a305091ded42e8fe8ed5a0c0efe03013
Patch Set 1 #
Messages
Total messages: 18 (10 generated)
The CQ bit was checked by emircan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== enable. BUG= ========== to ========== Enable MediaFoundationH264Encoding by default This CL enables this feature by default after the finch experiment. BUG=631783 ==========
emircan@chromium.org changed reviewers: + rkaplow@chromium.org, sdoyon@chromium.org
PTAL.
lgtm lgtm but probably should be reviewed by someone on the feature team. Don't forget to cleanup the experiment code at this time.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
On 2017/02/24 18:59:00, rkaplow (slow) wrote: > lgtm > > lgtm but probably should be reviewed by someone on the feature team. > > Don't forget to cleanup the experiment code at this time. Thanks. I added sdoyon@ to take a look as well. There is no unused experiment code right now and I want to keep the feature flag there as a kill switch in case of a problem.
LGTM -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
emircan@chromium.org changed reviewers: + sandersd@chromium.org
Thanks. sandersd@ RS review please?
lgtm
The CQ bit was checked by emircan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1487974275671220, "parent_rev": "a534bdcb6f2f02960bfd7bab54c0856403563281", "commit_rev": "2f52fcb3a305091ded42e8fe8ed5a0c0efe03013"}
Message was sent while issue was closed.
Description was changed from ========== Enable MediaFoundationH264Encoding by default This CL enables this feature by default after the finch experiment. BUG=631783 ========== to ========== Enable MediaFoundationH264Encoding by default This CL enables this feature by default after the finch experiment. BUG=631783 Review-Url: https://codereview.chromium.org/2714153004 Cr-Commit-Position: refs/heads/master@{#452948} Committed: https://chromium.googlesource.com/chromium/src/+/2f52fcb3a305091ded42e8fe8ed5... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/2f52fcb3a305091ded42e8fe8ed5... |