Clean up ImageView.

Clean up ImageView.

- remove set_interactive, which is redundant with
  View::set_can_process_events_within_subtree
- remove default focus painter, which is almost never used (only place
  I could find is PageActions, which have been dead code for a couple
  years now.)
- remove ability to set focus painter, which is literally never used.

BUG=696003
Review-Url: https://codereview.chromium.org/2713993005
Cr-Commit-Position: refs/heads/master@{#452984}
Committed: https://chromium.googlesource.com/chromium/src/+/f1d5292e67790a384c212c6e6d25f1655591aebf

[Evan Stade, 2017-02-24 21:02:19]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 21:03:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Evan Stade, 2017-02-24 21:04:32]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[Evan Stade, 2017-02-24 21:04:56]

estade@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org, sky@chromium.org

[Evan Stade, 2017-02-24 21:04:57]

+Devlin because of implications for page actions (see CL desc)
+sky for review

[commit-bot: I haz the power, 2017-02-24 21:05:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2017-02-24 21:32:33]

LGTM

https://codereview.chromium.org/2713993005/diff/20001/chrome/browser/shell_in...
File chrome/browser/shell_integration.h (right):

https://codereview.chromium.org/2713993005/diff/20001/chrome/browser/shell_in...
chrome/browser/shell_integration.h:137: // 
set_can_process_events_within_subtree_permitted(), in which case an attempt
optional: remove '_permitted'. It's unnecessary and mildly confusing. If you do
remove, also remove from the member.

[Devlin, 2017-02-24 21:34:47]

lgtm

[Evan Stade, 2017-02-24 21:39:10]

https://codereview.chromium.org/2713993005/diff/20001/chrome/browser/shell_in...
File chrome/browser/shell_integration.h (right):

https://codereview.chromium.org/2713993005/diff/20001/chrome/browser/shell_in...
chrome/browser/shell_integration.h:137: // 
set_can_process_events_within_subtree_permitted(), in which case an attempt
On 2017/02/24 21:32:33, sky wrote:
> optional: remove '_permitted'. It's unnecessary and mildly confusing. If you
do
> remove, also remove from the member.

oops, this was an overzealous find/replace. I've just gone through to verify
there were no other similar mistakes.

[Evan Stade, 2017-02-24 21:39:38]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2017-02-24 21:39:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2713993005/#ps40001
(title: "revert errant changes")

[commit-bot: I haz the power, 2017-02-24 21:40:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 23:13:29]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487972378578140,
"parent_rev": "ff7311159a7f270b38d2e696bf69ac5ee8da45ee", "commit_rev":
"f1d5292e67790a384c212c6e6d25f1655591aebf"}

[commit-bot: I haz the power, 2017-02-24 23:14:05]

Description was changed from

==========
Clean up ImageView.

- remove set_interactive, which is redundant with
  View::set_can_process_events_within_subtree
- remove default focus painter, which is almost never used (only place
  I could find is PageActions, which have been dead code for a couple
  years now.)
- remove ability to set focus painter, which is literally never used.

BUG=696003
==========

to

==========
Clean up ImageView.

- remove set_interactive, which is redundant with
  View::set_can_process_events_within_subtree
- remove default focus painter, which is almost never used (only place
  I could find is PageActions, which have been dead code for a couple
  years now.)
- remove ability to set focus painter, which is literally never used.

BUG=696003

Review-Url: https://codereview.chromium.org/2713993005
Cr-Commit-Position: refs/heads/master@{#452984}
Committed:
https://chromium.googlesource.com/chromium/src/+/f1d5292e67790a384c212c6e6d25...
==========

[commit-bot: I haz the power, 2017-02-24 23:14:06]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f1d5292e67790a384c212c6e6d25...