Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 2713683002: Fix issue where video scaling gets stuck at low resolution (Closed)

Created:
3 years, 10 months ago by magjed_webrtc
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix issue where video scaling gets stuck at low resolution This CL fixes issue 7211 as well as adding a test that would have caught the issue. BUG=webrtc:7211, webrtc:6850 ,b/35471214 R=sprang@webrtc.org TBR=kthelgason, sprang Review-Url: https://codereview.webrtc.org/2713683002 . Cr-Commit-Position: refs/heads/master@{#16778} Committed: https://chromium.googlesource.com/external/webrtc/+/6d230d7b1dcc31c6b7d57b50a2c6379f7f3e112d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M webrtc/media/base/videoadapter.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/base/videoadapter_unittest.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
magjed_webrtc
Please take a look. I'm going to TBR this since it's a trivial fix and ...
3 years, 10 months ago (2017-02-22 16:58:23 UTC) #5
sprang_webrtc
lgtm
3 years, 10 months ago (2017-02-22 17:02:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2713683002/1
3 years, 10 months ago (2017-02-22 17:09:25 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/builds/15858)
3 years, 10 months ago (2017-02-22 17:20:15 UTC) #13
magjed_webrtc
Committed patchset #1 (id:1) manually as 6d230d7b1dcc31c6b7d57b50a2c6379f7f3e112d (presubmit successful).
3 years, 10 months ago (2017-02-22 17:30:32 UTC) #15
kthelgason
3 years, 10 months ago (2017-02-23 08:05:19 UTC) #16
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698