Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issue 2713093005: Teach MainThreadEventQueue about touchmove throttling. (Closed)

Created:
3 years, 10 months ago by dtapuska
Modified:
3 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, dtapuska+chromiumwatch_chromium.org, jam, mlamouri+watch-content_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Teach MainThreadEventQueue about touchmove throttling. Avoid the rAF callbacks when we are throttling touch moves. To do this we check the last rAF time and see if there is a single touch move in the queue that is non-cancelable (only occurs during scrolling) BUG=642368 Review-Url: https://codereview.chromium.org/2713093005 Cr-Commit-Position: refs/heads/master@{#452985} Committed: https://chromium.googlesource.com/chromium/src/+/97286c88bded97a7254edd950b26712fd2a616e7

Patch Set 1 #

Total comments: 13

Patch Set 2 : Fix timestamps #

Patch Set 3 : Roll if/else condition together #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -22 lines) Patch
M content/renderer/input/input_event_filter.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/input/input_event_filter.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M content/renderer/input/input_handler_manager.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/input/input_handler_manager.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M content/renderer/input/input_handler_manager_client.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/input/main_thread_event_queue.h View 1 5 chunks +12 lines, -2 lines 0 comments Download
M content/renderer/input/main_thread_event_queue.cc View 1 2 7 chunks +47 lines, -10 lines 0 comments Download
M content/renderer/input/main_thread_event_queue_unittest.cc View 1 4 chunks +49 lines, -2 lines 0 comments Download
M content/renderer/render_widget.cc View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 23 (10 generated)
dtapuska
3 years, 10 months ago (2017-02-24 19:16:43 UTC) #5
dtapuska
https://codereview.chromium.org/2713093005/diff/1/content/renderer/input/main_thread_event_queue.h File content/renderer/input/main_thread_event_queue.h (right): https://codereview.chromium.org/2713093005/diff/1/content/renderer/input/main_thread_event_queue.h#newcode45 content/renderer/input/main_thread_event_queue.h:45: bool originallyCancelable() const { return originally_cancelable_; } Happy for ...
3 years, 10 months ago (2017-02-24 19:18:48 UTC) #6
tdresser
This LGTM.
3 years, 10 months ago (2017-02-24 19:51:25 UTC) #9
dtapuska
On 2017/02/24 19:51:25, tdresser wrote: > This LGTM. aelias@ do you care to look at ...
3 years, 10 months ago (2017-02-24 20:18:12 UTC) #10
aelias_OOO_until_Jul13
https://codereview.chromium.org/2713093005/diff/1/content/renderer/input/input_event_filter.h File content/renderer/input/input_event_filter.h (right): https://codereview.chromium.org/2713093005/diff/1/content/renderer/input/input_event_filter.h#newcode78 content/renderer/input/input_event_filter.h:78: void ProcessRafAlignedInput(int routing_id, double frame_time_sec) override; Please use base::Time. ...
3 years, 10 months ago (2017-02-24 20:19:51 UTC) #11
dtapuska
https://codereview.chromium.org/2713093005/diff/1/content/renderer/input/main_thread_event_queue.cc File content/renderer/input/main_thread_event_queue.cc (right): https://codereview.chromium.org/2713093005/diff/1/content/renderer/input/main_thread_event_queue.cc#newcode307 content/renderer/input/main_thread_event_queue.cc:307: if (handle_raf_aligned_touch_input_ && shared_state_.events_.size() == 1 && On 2017/02/24 ...
3 years, 10 months ago (2017-02-24 20:23:35 UTC) #12
dtapuska
On 2017/02/24 20:23:35, dtapuska wrote: > https://codereview.chromium.org/2713093005/diff/1/content/renderer/input/main_thread_event_queue.cc > File content/renderer/input/main_thread_event_queue.cc (right): > > https://codereview.chromium.org/2713093005/diff/1/content/renderer/input/main_thread_event_queue.cc#newcode307 > ...
3 years, 10 months ago (2017-02-24 20:24:19 UTC) #13
dtapuska
https://codereview.chromium.org/2713093005/diff/1/content/renderer/input/input_event_filter.h File content/renderer/input/input_event_filter.h (right): https://codereview.chromium.org/2713093005/diff/1/content/renderer/input/input_event_filter.h#newcode78 content/renderer/input/input_event_filter.h:78: void ProcessRafAlignedInput(int routing_id, double frame_time_sec) override; On 2017/02/24 20:19:50, ...
3 years, 10 months ago (2017-02-24 20:43:15 UTC) #14
aelias_OOO_until_Jul13
https://codereview.chromium.org/2713093005/diff/1/content/renderer/input/main_thread_event_queue.cc File content/renderer/input/main_thread_event_queue.cc (right): https://codereview.chromium.org/2713093005/diff/1/content/renderer/input/main_thread_event_queue.cc#newcode307 content/renderer/input/main_thread_event_queue.cc:307: if (handle_raf_aligned_touch_input_ && shared_state_.events_.size() == 1 && On 2017/02/24 ...
3 years, 10 months ago (2017-02-24 21:01:14 UTC) #15
dtapuska
https://codereview.chromium.org/2713093005/diff/1/content/renderer/input/main_thread_event_queue.cc File content/renderer/input/main_thread_event_queue.cc (right): https://codereview.chromium.org/2713093005/diff/1/content/renderer/input/main_thread_event_queue.cc#newcode307 content/renderer/input/main_thread_event_queue.cc:307: if (handle_raf_aligned_touch_input_ && shared_state_.events_.size() == 1 && On 2017/02/24 ...
3 years, 10 months ago (2017-02-24 21:29:41 UTC) #16
aelias_OOO_until_Jul13
lgtm
3 years, 10 months ago (2017-02-24 21:34:54 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2713093005/40001
3 years, 10 months ago (2017-02-24 21:37:59 UTC) #20
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 23:15:26 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/97286c88bded97a7254edd950b26...

Powered by Google App Engine
This is Rietveld 408576698