WTF::Vector: Add detailed explanation as class-level comments.

WTF::Vector: Add detailed explanation as class-level comments.

This change should cover almost all the use cases and common traps of Vector.

BUG=690816
Review-Url: https://codereview.chromium.org/2712643002
Cr-Commit-Position: refs/heads/master@{#452443}
Committed: https://chromium.googlesource.com/chromium/src/+/360b16ec95b18a11357e354b3b3db1080264f757

[Yuta Kitamura, 2017-02-22 09:22:59]

yutak@chromium.org changed reviewers:
+ haraken@chromium.org, tzik@chromium.org

[Yuta Kitamura, 2017-02-22 09:22:59]

I'm adding looooong comments for Vector. PTAL?

[haraken, 2017-02-22 09:55:16]

LGTM

https://codereview.chromium.org/2712643002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/wtf/Vector.h (right):

https://codereview.chromium.org/2712643002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/Vector.h:912: // garbage-collected type is wrapped
with Member or WeakMember, like:

WeakMember is not supported in HeapVector.

https://codereview.chromium.org/2712643002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/Vector.h:926: // some GC operation, like normal
WeakMembers.

Remove this paragraph.

[tzik, 2017-02-22 10:46:27]

lgtm

[Yuta Kitamura, 2017-02-23 06:33:28]

https://codereview.chromium.org/2712643002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/wtf/Vector.h (right):

https://codereview.chromium.org/2712643002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/Vector.h:912: // garbage-collected type is wrapped
with Member or WeakMember, like:
On 2017/02/22 09:55:15, haraken wrote:
> 
> WeakMember is not supported in HeapVector.

Done.

https://codereview.chromium.org/2712643002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/Vector.h:926: // some GC operation, like normal
WeakMembers.
On 2017/02/22 09:55:15, haraken wrote:
> 
> Remove this paragraph.

Done.

[Yuta Kitamura, 2017-02-23 06:33:34]

The CQ bit was checked by yutak@chromium.org

[Yuta Kitamura, 2017-02-23 06:33:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, tzik@chromium.org
Link to the patchset: https://codereview.chromium.org/2712643002/#ps20001
(title: "Don't mention WeakMember.")

[commit-bot: I haz the power, 2017-02-23 06:33:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 09:40:50]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487831614073780,
"parent_rev": "a9e4f703d78e0cf23ecba81eced44ec3a9712bec", "commit_rev":
"360b16ec95b18a11357e354b3b3db1080264f757"}

[commit-bot: I haz the power, 2017-02-23 09:41:26]

Description was changed from

==========
WTF::Vector: Add detailed explanation as class-level comments.

This change should cover almost all the use cases and common traps of Vector.

BUG=690816
==========

to

==========
WTF::Vector: Add detailed explanation as class-level comments.

This change should cover almost all the use cases and common traps of Vector.

BUG=690816

Review-Url: https://codereview.chromium.org/2712643002
Cr-Commit-Position: refs/heads/master@{#452443}
Committed:
https://chromium.googlesource.com/chromium/src/+/360b16ec95b18a11357e354b3b3d...
==========

[commit-bot: I haz the power, 2017-02-23 09:41:27]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/360b16ec95b18a11357e354b3b3d...