Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2712353002: DxgiOutputDuplicator AcquireNextFrame timeout can be 0 (Closed)

Created:
3 years, 9 months ago by Hzj_jie
Modified:
3 years, 9 months ago
Reviewers:
Sergey Ulanov
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, Jamie
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

DxgiOutputDuplicator AcquireNextFrame timeout can be 0 Timeout of AcquireNextFrame() can be 0. Though MSDN does not state it clear, I tried it on my laptop, it works well, with almost zero capture time. The screenshot is at https://drive.google.com/open?id=0B0OFNI4uoZGRNVZxekxCbm0ycmc. BUG=682112 Review-Url: https://codereview.webrtc.org/2712353002 Cr-Commit-Position: refs/heads/master@{#16953} Committed: https://chromium.googlesource.com/external/webrtc/+/634fcb32e34413da621445722df1a21cb44a32c4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M webrtc/modules/desktop_capture/win/dxgi_output_duplicator.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Hzj_jie
3 years, 9 months ago (2017-02-27 00:11:18 UTC) #5
Sergey Ulanov
lgtm
3 years, 9 months ago (2017-03-01 18:15:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2712353002/1
3 years, 9 months ago (2017-03-01 19:22:08 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 19:45:41 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/634fcb32e34413da621445722...

Powered by Google App Engine
This is Rietveld 408576698