Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 2711783005: Adding suppression for race in stats collector test. (Closed)

Created:
3 years, 10 months ago by Taylor Brandstetter
Modified:
3 years, 10 months ago
Reviewers:
hbos
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adding suppression for race in stats collector test. See bug for more info. This race is benign, and only exists because a method is virtual so it can be mocked for testing. BUG=webrtc:7221 NOTRY=True TBR=hbos@webrtc.org Review-Url: https://codereview.webrtc.org/2711783005 Cr-Commit-Position: refs/heads/master@{#16813} Committed: https://chromium.googlesource.com/external/webrtc/+/2b62fa218c3af2e4ce6e4e9a6cddcc55ad07fcba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M tools-webrtc/sanitizers/tsan_suppressions_webrtc.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Taylor Brandstetter
3 years, 10 months ago (2017-02-24 03:02:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2711783005/1
3 years, 10 months ago (2017-02-24 03:03:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/2b62fa218c3af2e4ce6e4e9a6cddcc55ad07fcba
3 years, 10 months ago (2017-02-24 03:05:43 UTC) #8
hbos
3 years, 10 months ago (2017-02-24 11:13:04 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698