Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1078)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2711633006: [wasm] Reuse constrained input for same vreg

Created:
3 years, 10 months ago by Mircea Trofin
Modified:
3 years, 9 months ago
Reviewers:
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Reuse constrained input for same vreg consider: instruction v1(R) v2 v1(=rcx) The first input could just be set to "rcx", no need to further allocate. [turbofan] Teach x64 tail-call jmp about complex addressing modes WIP: Allow VisitTailCall with a CallAddress descriptor to check for a Load as its callee input (as is the case in Ignition dispatch calls). Instead of materializing this Load, we can instead inline it as a memory operand. Currently only implemented for x64, implementations for other architectures should be relatively trivial. BUG=v8:5993 Change-Id: Id8e1ed4bc966db6a84fec89539f0a7a7267c7cea

Patch Set 1 : . #

Patch Set 2 #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : alternative mulpair #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -47 lines) Patch
M src/compiler/ia32/code-generator-ia32.cc View 1 2 3 4 1 chunk +3 lines, -9 lines 0 comments Download
M src/compiler/ia32/instruction-codes-ia32.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ia32/instruction-scheduler-ia32.cc View 1 2 3 4 2 chunks +1 line, -1 line 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 2 3 4 1 chunk +20 lines, -13 lines 0 comments Download
M src/compiler/instruction-selector-impl.h View 1 2 3 4 2 chunks +13 lines, -3 lines 0 comments Download
M src/compiler/register-allocator.cc View 1 2 3 4 chunks +60 lines, -20 lines 0 comments Download

Messages

Total messages: 21 (21 generated)
Mircea Trofin
Patchset #1 (id:1) has been deleted
3 years, 10 months ago (2017-02-23 02:24:28 UTC) #1
Mircea Trofin
The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run
3 years, 10 months ago (2017-02-23 02:24:36 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2711633006/20001
3 years, 10 months ago (2017-02-23 02:24:43 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-23 02:39:13 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/builds/13588) v8_linux64_gyp_rel_ng_triggered on ...
3 years, 10 months ago (2017-02-23 02:39:14 UTC) #5
Mircea Trofin
The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run
3 years, 10 months ago (2017-02-23 03:33:50 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2711633006/30001
3 years, 10 months ago (2017-02-23 03:33:54 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-23 03:48:43 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/builds/13589) v8_linux64_gyp_rel_ng_triggered on ...
3 years, 10 months ago (2017-02-23 03:48:44 UTC) #9
Mircea Trofin
The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run
3 years, 10 months ago (2017-02-23 06:17:11 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2711633006/50001
3 years, 10 months ago (2017-02-23 06:17:15 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-23 06:35:40 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_verify_csa_rel_ng/builds/1397) v8_linux_verify_csa_rel_ng_triggered on ...
3 years, 10 months ago (2017-02-23 06:35:41 UTC) #13
Mircea Trofin
The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run
3 years, 10 months ago (2017-02-23 23:17:16 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2711633006/70001
3 years, 10 months ago (2017-02-23 23:17:22 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-23 23:37:35 UTC) #16
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/17990) v8_mac_rel_ng_triggered on ...
3 years, 10 months ago (2017-02-23 23:37:36 UTC) #17
Mircea Trofin
The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-02-24 21:13:59 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2711633006/90001
3 years, 9 months ago (2017-02-24 21:14:03 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-02-24 21:36:06 UTC) #20
commit-bot: I haz the power
3 years, 9 months ago (2017-02-24 21:36:07 UTC) #21 
Dry run: Try jobs failed on following builders:
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_arm_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng_trigger...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_nodcheck_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng_tr...)

Powered by Google App Engine
This is Rietveld 408576698