Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 2711113008: Adding rtc::Unretained to allow avoiding rtc::Bind reference capture. (Closed)

Created:
3 years, 9 months ago by Taylor Brandstetter
Modified:
3 years, 9 months ago
Reviewers:
tommi, pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adding rtc::Unretained to allow avoiding rtc::Bind reference capture. In some rare circumstances, capturing a reference may be undesired. For example, when creating an asynchronous task owned by the object itself, the object may not need or want this task to keep itself alive. BUG=None Review-Url: https://codereview.webrtc.org/2711113008 Cr-Commit-Position: refs/heads/master@{#16840} Committed: https://chromium.googlesource.com/external/webrtc/+/ccaaffb44a7f98e68a6763675a2cc8ae02635d6e

Patch Set 1 #

Patch Set 2 : Rebase onto master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -8 lines) Patch
M webrtc/base/bind.h View 1 5 chunks +66 lines, -8 lines 0 comments Download
M webrtc/base/bind_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Taylor Brandstetter
3 years, 9 months ago (2017-02-25 11:17:35 UTC) #2
tommi
lgtm
3 years, 9 months ago (2017-02-25 14:04:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2711113008/20001
3 years, 9 months ago (2017-02-25 19:52:24 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-02-25 20:56:26 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/ccaaffb44a7f98e68a6763675...

Powered by Google App Engine
This is Rietveld 408576698