Step #3: Add flag for correctness mode in VideoProcessor integration tests.

webrtc/modules/video_coding/codecs/test/plot_videoprocessor_integrationtest.cc

Index: webrtc/modules/video_coding/codecs/test/plot_videoprocessor_integrationtest.cc
diff --git a/webrtc/modules/video_coding/codecs/test/plot_videoprocessor_integrationtest.cc b/webrtc/modules/video_coding/codecs/test/plot_videoprocessor_integrationtest.cc
index d11398b91146b680f898ea203c2353a4fddf0766..70fadce5b32781cf8f0086e6895747993e77579e 100644
--- a/webrtc/modules/video_coding/codecs/test/plot_videoprocessor_integrationtest.cc
+++ b/webrtc/modules/video_coding/codecs/test/plot_videoprocessor_integrationtest.cc
@@ -26,6 +26,7 @@ const bool kHwCodec = false;
 const bool kUseSingleCore = true;
 
 // Test settings.
+const bool kCorrectnessMode = false;
 const bool kBatchMode = true;
 
 // Packet loss probability [0.0, 1.0].
@@ -69,7 +70,7 @@ class PlotVideoProcessorIntegrationTest
         -1,  // key_frame_interval
         1,   // num_temporal_layers
         kErrorConcealmentOn, kDenoisingOn, kFrameDropperOn, kSpatialResizeOn,
-        width, height, filename, kVerboseLogging, kBatchMode);
+        width, height, filename, kVerboseLogging, kCorrectnessMode, kBatchMode);
     // Thresholds for expected quality (PSNR avg, PSNR min, SSIM avg, SSIM min).
     QualityThresholds quality_thresholds;
     SetQualityThresholds(&quality_thresholds, 15.0, 10.0, 0.2, 0.1);

[åsapersson, 2017/03/09 11:48:57]

Maybe the thresholds could be configured to some value that will always pass
(e.g. zero for the quality thresholds)? The quality thresholds could maybe be
initialized to 0 and the call to SetQualityThresholds removed.

[brandtr, 2017/03/09 12:07:02]

Yes, I considered that. But I would still have to disable these EXPECT_EQ's:
https://cs.chromium.org/chromium/src/third_party/webrtc/modules/video_coding/...

What I could do instead is to implicitly disable the EXPECT_GE/EXPECT_LE's by
setting the thresholds appropriately low/high, and then explicitly disable the
EXPECT_EQ's by setting the corresponding threshold to -1, and then just check
that locally. That is probably a cleaner solution, what do you think?

[åsapersson, 2017/03/09 12:46:47]

Sounds good to me.