Step #3: Add flag for correctness mode in VideoProcessor integration tests.

webrtc/modules/video_coding/codecs/test/plot_videoprocessor_integrationtest.cc

 /*
  *  Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include "webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h"
 
 namespace webrtc {
 namespace test {
 
 namespace {
 // Codec settings.
 const int kBitrates[] = {30, 50, 100, 200, 300, 500, 1000};
 const int kFps[] = {30};
 const bool kErrorConcealmentOn = false;
 const bool kDenoisingOn = false;
 const bool kFrameDropperOn = true;
 const bool kSpatialResizeOn = false;
 const VideoCodecType kVideoCodecType[] = {kVideoCodecVP8};
 const bool kHwCodec = false;
 const bool kUseSingleCore = true;
 
 // Test settings.
+const bool kCorrectnessMode = false;
 const bool kBatchMode = true;
 
 // Packet loss probability [0.0, 1.0].
 const float kPacketLoss = 0.0f;
 
 const VisualizationParams kVisualizationParams = {
     false,  // save_source_y4m
     false,  // save_encoded_ivf
     false,  // save_decoded_y4m
 };
@@ skipping 23 matching lines @@
                    0);  // frame_index_rate_update
     rate_profile.frame_index_rate_update[1] = kNumFramesLong + 1;
     rate_profile.num_frames = kNumFramesLong;
     // Codec/network settings.
     CodecParams process_settings;
     SetCodecParams(
         &process_settings, codec_type_, kHwCodec, kUseSingleCore, kPacketLoss,
         -1,  // key_frame_interval
         1,   // num_temporal_layers
         kErrorConcealmentOn, kDenoisingOn, kFrameDropperOn, kSpatialResizeOn,
-        width, height, filename, kVerboseLogging, kBatchMode);
+        width, height, filename, kVerboseLogging, kCorrectnessMode, kBatchMode);
     // Thresholds for expected quality (PSNR avg, PSNR min, SSIM avg, SSIM min).
     QualityThresholds quality_thresholds;
     SetQualityThresholds(&quality_thresholds, 15.0, 10.0, 0.2, 0.1);

[åsapersson, 2017/03/09 11:48:57]

Maybe the thresholds could be configured to some value that will always pass
(e.g. zero for the quality thresholds)? The quality thresholds could maybe be
initialized to 0 and the call to SetQualityThresholds removed.

[brandtr, 2017/03/09 12:07:02]

Yes, I considered that. But I would still have to disable these EXPECT_EQ's:
https://cs.chromium.org/chromium/src/third_party/webrtc/modules/video_coding/...

What I could do instead is to implicitly disable the EXPECT_GE/EXPECT_LE's by
setting the thresholds appropriately low/high, and then explicitly disable the
EXPECT_EQ's by setting the corresponding threshold to -1, and then just check
that locally. That is probably a cleaner solution, what do you think?

[åsapersson, 2017/03/09 12:46:47]

Sounds good to me.

     // Thresholds for rate control.
     RateControlThresholds rc_thresholds[1];
     SetRateControlThresholds(rc_thresholds,
                              0,    // update_index
                              300,  // max_num_dropped_frames,
                              400,  // max_key_frame_size_mismatch
                              200,  // max_delta_frame_size_mismatch
                              100,  // max_encoding_rate_mismatch
                              300,  // max_time_hit_target
                              0,    // num_spatial_resizes
@@ skipping 28 matching lines @@
 TEST_P(PlotVideoProcessorIntegrationTest, Process320x240) {
   RunTest(320, 240, "foreman_320x240");
 }
 
 TEST_P(PlotVideoProcessorIntegrationTest, Process352x288) {
   RunTest(352, 288, "foreman_cif");
 }
 
 }  // namespace test
 }  // namespace webrtc