Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 2710823004: Revert of Explicitly call SequenceToken's default constructor. (Closed)

Created:
3 years, 10 months ago by jif
Modified:
3 years, 10 months ago
Reviewers:
danakj
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Explicitly call SequenceToken's default constructor. (patchset #2 id:20001 of https://codereview.chromium.org/2184353003/ ) Reason for revert: xcode's clang now supports const default initialization. Original issue's description: > Explicitly call SequenceToken's default constructor. > > This CL is to workaround a clang bug occurring when building > sequence_token_unittest.cc for Chrome iOS. > > BUG=632330 > > Committed: https://crrev.com/0240044e435a3708d3f082771943a498a4cf3592 > Cr-Commit-Position: refs/heads/master@{#408515} TBR=danakj@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=632330

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M base/sequence_token_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jif
Created Revert of Explicitly call SequenceToken's default constructor.
3 years, 10 months ago (2017-02-22 10:18:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2710823004/1
3 years, 10 months ago (2017-02-22 10:19:09 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-clang/builds/43227) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 10 months ago (2017-02-22 10:33:29 UTC) #5
jif
3 years, 10 months ago (2017-02-22 10:37:35 UTC) #6
So apparently xcode's clang still does NOT supports const default
initialization.
Closing CL.

Powered by Google App Engine
This is Rietveld 408576698