Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2710493002: Fix partial availability warnings on Mac AppRTCMobile (Closed)

Created:
3 years, 10 months ago by magjed_webrtc
Modified:
3 years, 10 months ago
Reviewers:
kthelgason
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix partial availability warnings on Mac AppRTCMobile The partial availability problem aries from the fact that the minimum supported OSX version is set to 10.9, but AppRTCMobile is using functions available only in 10.10 and later. The minimum OSX version is set as a declare_args() in build/config/mac/mac_sdk.gni, which makes it difficult to override for just the AppRTCMobile target in WebRTC. Instead, this CL solves the problem for now by removing the usage of the 10.10 function, which is trivial. Also, the flag: 'extra_substitutions = [ "MACOSX_DEPLOYMENT_TARGET=10.8" ]' is removed since it has no effect. BUG=webrtc:4695 Review-Url: https://codereview.webrtc.org/2710493002 Cr-Commit-Position: refs/heads/master@{#16726} Committed: https://chromium.googlesource.com/external/webrtc/+/a445b9bca72606e55970135f0f1023e7c486d31e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -10 lines) Patch
M webrtc/examples/BUILD.gn View 3 chunks +0 lines, -9 lines 0 comments Download
M webrtc/examples/objc/AppRTCMobile/mac/APPRTCViewController.m View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
magjed_webrtc
Kári - please take a look.
3 years, 10 months ago (2017-02-20 14:34:48 UTC) #7
kthelgason
wow, ok. lgtm!
3 years, 10 months ago (2017-02-20 14:46:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2710493002/1
3 years, 10 months ago (2017-02-20 15:54:19 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 15:56:57 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/a445b9bca72606e55970135f0...

Powered by Google App Engine
This is Rietveld 408576698