Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 2710433003: Move filerotatingstream_unittest.cc to rtc_base_nonparallel_tests. (Closed)

Created:
3 years, 10 months ago by Taylor Brandstetter
Modified:
3 years, 10 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move filerotatingstream_unittest.cc to rtc_base_nonparallel_tests. These tests involve interactions with the file system, so to avoid flakiness they shouldn't be run in parallel. BUG=webrtc:7195 NOTRY=True Review-Url: https://codereview.webrtc.org/2710433003 Cr-Commit-Position: refs/heads/master@{#16727} Committed: https://chromium.googlesource.com/external/webrtc/+/4024b9bbe69911f24958d5e76a685242a30e15d9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/base/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
Taylor Brandstetter
3 years, 10 months ago (2017-02-20 11:22:58 UTC) #2
kjellander_webrtc
lgtm I added NOTRY=True for you. The test would ideally be fixed instead though (using ...
3 years, 10 months ago (2017-02-20 14:49:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2710433003/1
3 years, 10 months ago (2017-02-20 20:05:35 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 20:07:55 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/4024b9bbe69911f24958d5e76...

Powered by Google App Engine
This is Rietveld 408576698