Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2710023010:
Fix busy loop in FakeAudioDeviceModule. (Closed)
DescriptionFix busy loop in FakeAudioDeviceModule.
The implementation now has a mechanism that effectively turns off callbacks if used.
BUG=webrtc:7237, 695438
TBR=solenberg@webrtc.org
Review-Url: https://codereview.webrtc.org/2710023010
Cr-Commit-Position: refs/heads/master@{#16837}
Committed: https://chromium.googlesource.com/external/webrtc/+/4af9f962c3a79b97c4b2d85be4c30c9b77ef7a21
Patch Set 1 #Patch Set 2 : Add some logic to reduce callbacks when appropriate #
Total comments: 3
Messages
Total messages: 18 (12 generated)
Add some logic to reduce callbacks when appropriate
Description was changed from ========== Fix busy loop in FakeAudioDeviceModule. I'm making it slightly less busy by doing nothing (by default) every 10ms (instead of ever 0ms). BUG= ========== to ========== Fix busy loop in FakeAudioDeviceModule. I'm making it slightly less busy by doing nothing (by default) every 10ms (instead of ever 0ms). BUG=webrtc:7237 ==========
tommi@webrtc.org changed reviewers: + solenberg@webrtc.org
The CQ bit was checked by tommi@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Description was changed from ========== Fix busy loop in FakeAudioDeviceModule. I'm making it slightly less busy by doing nothing (by default) every 10ms (instead of ever 0ms). BUG=webrtc:7237 ========== to ========== Fix busy loop in FakeAudioDeviceModule. The implementation now has a mechanism that effectively turns off callbacks if used. BUG=webrtc:7237 ==========
Description was changed from ========== Fix busy loop in FakeAudioDeviceModule. The implementation now has a mechanism that effectively turns off callbacks if used. BUG=webrtc:7237 ========== to ========== Fix busy loop in FakeAudioDeviceModule. The implementation now has a mechanism that effectively turns off callbacks if used. BUG=webrtc:7237, 695438 ==========
Hej Fredrik - I think I'll tbr this change to see the impact on the perf bots in isolation before the week starts.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Fix busy loop in FakeAudioDeviceModule. The implementation now has a mechanism that effectively turns off callbacks if used. BUG=webrtc:7237, 695438 ========== to ========== Fix busy loop in FakeAudioDeviceModule. The implementation now has a mechanism that effectively turns off callbacks if used. BUG=webrtc:7237, 695438 TBR=solenberg@webrtc.org ==========
The CQ bit was checked by tommi@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488042157343570,
"parent_rev": "d74517c52a6cd4172b1f3fdc4e624b6145ff5a0f", "commit_rev":
"4af9f962c3a79b97c4b2d85be4c30c9b77ef7a21"}
Message was sent while issue was closed.
Description was changed from ========== Fix busy loop in FakeAudioDeviceModule. The implementation now has a mechanism that effectively turns off callbacks if used. BUG=webrtc:7237, 695438 TBR=solenberg@webrtc.org ========== to ========== Fix busy loop in FakeAudioDeviceModule. The implementation now has a mechanism that effectively turns off callbacks if used. BUG=webrtc:7237, 695438 TBR=solenberg@webrtc.org Review-Url: https://codereview.webrtc.org/2710023010 Cr-Commit-Position: refs/heads/master@{#16837} Committed: https://chromium.googlesource.com/external/webrtc/+/4af9f962c3a79b97c4b2d85be... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/4af9f962c3a79b97c4b2d85be...
Message was sent while issue was closed.
lgtm but see comments for an alternative with less boolean mungery. https://codereview.webrtc.org/2710023010/diff/20001/webrtc/modules/audio_devi... File webrtc/modules/audio_device/include/fake_audio_device.h (right): https://codereview.webrtc.org/2710023010/diff/20001/webrtc/modules/audio_devi... webrtc/modules/audio_device/include/fake_audio_device.h:48: if (turn_off_module_callbacks_) return time_until_next_process_; https://codereview.webrtc.org/2710023010/diff/20001/webrtc/modules/audio_devi... webrtc/modules/audio_device/include/fake_audio_device.h:55: turn_off_module_callbacks_ = uses_default_module_implementation_; // After first call to Process(), we wait a long time to avoid hogging CPU. time_until_next_process_ = 7 * 24 * 60 * 60 * 1000; // call me next week. https://codereview.webrtc.org/2710023010/diff/20001/webrtc/modules/audio_devi... webrtc/modules/audio_device/include/fake_audio_device.h:184: bool uses_default_module_implementation_ = false; int64_t time_until_next_process_ = 10; |
