Add QP statistics to VideoProcessorIntegrationTest.

Add QP statistics to VideoProcessorIntegrationTest.

The average QP of encoded frames is printed in Stats::PrintSummary.

plot_webrtc_test_logs.py: Add QP to plots.

BUG=webrtc:6634
Review-Url: https://codereview.webrtc.org/2709613005
Cr-Commit-Position: refs/heads/master@{#16790}
Committed: https://chromium.googlesource.com/external/webrtc/+/abc0080df81066ce5f2de62f37c06c343b05ed16

[åsapersson, 2017-02-22 09:56:35]

Description was changed from

==========
Add QP statistics to VideoProcessorIntegrationTest.

The average QP of encoded frames is printed in Stats::PrintSummary.

BUG=webrtc:6634
==========

to

==========
Add QP statistics to VideoProcessorIntegrationTest.

The average QP of encoded frames is printed in Stats::PrintSummary.

plot_webrtc_test_logs.py: Add QP to plots.

BUG=webrtc:6634
==========

[åsapersson, 2017-02-22 09:59:19]

asapersson@webrtc.org changed reviewers:
+ brandtr@webrtc.org, sprang@webrtc.org

[brandtr, 2017-02-22 10:10:30]

lgtm.

Will be interesting to see the plots.

[åsapersson, 2017-02-22 10:13:17]

The CQ bit was checked by asapersson@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 10:13:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-22 11:14:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 11:14:36]

Dry run: This issue passed the CQ dry run.

[sprang_webrtc, 2017-02-22 16:59:01]

lgtm with nit
Damn, I could go for a royale with cheese now..

https://codereview.webrtc.org/2709613005/diff/1/webrtc/modules/video_coding/c...
File webrtc/modules/video_coding/codecs/test/stats.cc (right):

https://codereview.webrtc.org/2709613005/diff/1/webrtc/modules/video_coding/c...
webrtc/modules/video_coding/codecs/test/stats.cc:95: if (it->qp != -1) {
maybe even >= 0 just to be sure

[åsapersson, 2017-02-22 17:09:56]

The CQ bit was checked by asapersson@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 17:10:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[åsapersson, 2017-02-22 17:10:37]

https://codereview.webrtc.org/2709613005/diff/1/webrtc/modules/video_coding/c...
File webrtc/modules/video_coding/codecs/test/stats.cc (right):

https://codereview.webrtc.org/2709613005/diff/1/webrtc/modules/video_coding/c...
webrtc/modules/video_coding/codecs/test/stats.cc:95: if (it->qp != -1) {
On 2017/02/22 16:59:01, språng wrote:
> maybe even >= 0 just to be sure

Done.

[commit-bot: I haz the power, 2017-02-22 17:23:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 17:23:15]

Dry run: Try jobs failed on following builders:
  mac_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/19088)

[åsapersson, 2017-02-23 07:54:37]

The CQ bit was checked by asapersson@webrtc.org

[åsapersson, 2017-02-23 07:54:37]

The patchset sent to the CQ was uploaded after l-g-t-m from brandtr@webrtc.org,
sprang@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2709613005/#ps20001 (title:
"address comment")

[commit-bot: I haz the power, 2017-02-23 07:54:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-23 08:12:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 08:12:17]

Failed to apply patch for
webrtc/modules/video_coding/codecs/test/videoprocessor.cc:
While running git apply --index -p1;
  error: patch failed:
webrtc/modules/video_coding/codecs/test/videoprocessor.cc:281
  error: webrtc/modules/video_coding/codecs/test/videoprocessor.cc: patch does
not apply

Patch:       webrtc/modules/video_coding/codecs/test/videoprocessor.cc
Index: webrtc/modules/video_coding/codecs/test/videoprocessor.cc
diff --git a/webrtc/modules/video_coding/codecs/test/videoprocessor.cc
b/webrtc/modules/video_coding/codecs/test/videoprocessor.cc
index
99a34fc60ee6446781a4e9924b40b17f110c9bf0..6ee5bc9822b706a3d79c1d885e18d8b14f7f88e7
100644
--- a/webrtc/modules/video_coding/codecs/test/videoprocessor.cc
+++ b/webrtc/modules/video_coding/codecs/test/videoprocessor.cc
@@ -281,6 +281,7 @@ void VideoProcessorImpl::FrameEncoded(
   stat.encoded_frame_length_in_bytes = encoded_image._length;
   stat.frame_number = encoded_image._timeStamp;
   stat.frame_type = encoded_image._frameType;
+  stat.qp = encoded_image.qp_;
   stat.bit_rate_in_kbps = encoded_image._length * bit_rate_factor_;
   stat.total_packets =
       encoded_image._length / config_.networking_config.packet_size_in_bytes +

[åsapersson, 2017-02-23 08:31:30]

The CQ bit was checked by asapersson@webrtc.org

[åsapersson, 2017-02-23 08:31:30]

The patchset sent to the CQ was uploaded after l-g-t-m from brandtr@webrtc.org,
sprang@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2709613005/#ps40001 (title:
"rebase")

[commit-bot: I haz the power, 2017-02-23 08:31:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-23 09:33:04]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487838690451450,
"parent_rev": "61a2b1bd6cf5a2c4dfd4b5e21eab706fdb02ecdd", "commit_rev":
"abc0080df81066ce5f2de62f37c06c343b05ed16"}

[commit-bot: I haz the power, 2017-02-23 09:33:07]

Description was changed from

==========
Add QP statistics to VideoProcessorIntegrationTest.

The average QP of encoded frames is printed in Stats::PrintSummary.

plot_webrtc_test_logs.py: Add QP to plots.

BUG=webrtc:6634
==========

to

==========
Add QP statistics to VideoProcessorIntegrationTest.

The average QP of encoded frames is printed in Stats::PrintSummary.

plot_webrtc_test_logs.py: Add QP to plots.

BUG=webrtc:6634

Review-Url: https://codereview.webrtc.org/2709613005
Cr-Commit-Position: refs/heads/master@{#16790}
Committed:
https://chromium.googlesource.com/external/webrtc/+/abc0080df81066ce5f2de62f3...
==========

[commit-bot: I haz the power, 2017-02-23 09:33:08]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/abc0080df81066ce5f2de62f3...