|
|
Created:
3 years, 10 months ago by Qiang(Joe) Xu Modified:
3 years, 10 months ago CC:
chromium-reviews, alemate+watch_chromium.org, sadrul, achuith+watch_chromium.org, oshima+watch_chromium.org, kalyank, davemoore+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRevert of Signin screen and locked screen status area focus advancing (https://codereview.chromium.org/2295843006)
Revert reason:
Revert to get rid of the crash before having a proper fix.
BUG=692784
BUG=468969
TEST=crash doesn't happen now, leaving the bug in crbug.com/468969 comment 7 reopen.
Review-Url: https://codereview.chromium.org/2709593002
Cr-Commit-Position: refs/heads/master@{#451983}
Committed: https://chromium.googlesource.com/chromium/src/+/26f01531f9e0ecd2e0cde6cf5dacb0e4b70610ce
Patch Set 1 : revert 2295843006 #
Messages
Total messages: 29 (17 generated)
The CQ bit was checked by warx@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Patchset #2 (id:20001) has been deleted
Description was changed from ========== cros: Fix the crash on tabbing through status area BUG=692784 BUG=468969 ========== to ========== cros: Fix the crash on tabbing through status area by reverting 2295843006 Changes: Revert https://codereview.chromium.org/2295843006, as it causes crash. BUG=692784 BUG=468969 TEST=crash doesn't happen now, leaving the bug in crbug.com/468969 comment 7 reopen. ==========
warx@chromium.org changed reviewers: + stevenjb@chromium.org, xiyuan@chromium.org
Hi all, ptal, thanks!
lgtm I would say revert to get rid of the crash before having a proper fix, rather than claiming fixing the crash. :p
On 2017/02/21 22:04:32, xiyuan wrote: > lgtm > > I would say revert to get rid of the crash before having a proper fix, rather > than claiming fixing the crash. :p Also, for clarity, the CL title should be 'Revert of Signin screen and locked screen status area focus advancing (https://codereview.chromium.org/2295843006)' Be sure to update the first line of the description too, and leave the 'Fix the crash on ...' in the description as an explanation for the revert.
Description was changed from ========== cros: Fix the crash on tabbing through status area by reverting 2295843006 Changes: Revert https://codereview.chromium.org/2295843006, as it causes crash. BUG=692784 BUG=468969 TEST=crash doesn't happen now, leaving the bug in crbug.com/468969 comment 7 reopen. ========== to ========== Revert of Signin screen and locked screen status area focus advancing (https://codereview.chromium.org/2295843006)' Revert reason: Revert to get rid of the crash before having a proper fix. BUG=692784 BUG=468969 TEST=crash doesn't happen now, leaving the bug in crbug.com/468969 comment 7 reopen. ==========
Description was changed from ========== Revert of Signin screen and locked screen status area focus advancing (https://codereview.chromium.org/2295843006)' Revert reason: Revert to get rid of the crash before having a proper fix. BUG=692784 BUG=468969 TEST=crash doesn't happen now, leaving the bug in crbug.com/468969 comment 7 reopen. ========== to ========== Revert of Signin screen and locked screen status area focus advancing (https://codereview.chromium.org/2295843006) Revert reason: Revert to get rid of the crash before having a proper fix. BUG=692784 BUG=468969 TEST=crash doesn't happen now, leaving the bug in crbug.com/468969 comment 7 reopen. ==========
On 2017/02/21 22:10:58, stevenjb wrote: > On 2017/02/21 22:04:32, xiyuan wrote: > > lgtm > > > > I would say revert to get rid of the crash before having a proper fix, rather > > than claiming fixing the crash. :p > > Also, for clarity, the CL title should be 'Revert of Signin screen and locked > screen status area focus advancing (https://codereview.chromium.org/2295843006) > > Be sure to update the first line of the description too, and leave the 'Fix the > crash on ...' in the description as an explanation for the revert. done, thanks. Oh, I probably should just click the revert button on the original cl, right?
On 2017/02/21 22:18:01, Qiang(Joe) Xu wrote: > On 2017/02/21 22:10:58, stevenjb wrote: > > On 2017/02/21 22:04:32, xiyuan wrote: > > > lgtm > > > > > > I would say revert to get rid of the crash before having a proper fix, > rather > > > than claiming fixing the crash. :p > > > > Also, for clarity, the CL title should be 'Revert of Signin screen and locked > > screen status area focus advancing > (https://codereview.chromium.org/2295843006) > > > > Be sure to update the first line of the description too, and leave the 'Fix > the > > crash on ...' in the description as an explanation for the revert. > > done, thanks. Oh, I probably should just click the revert button on the original > cl, right? That would work too :) Either way, lgtm
The CQ bit was checked by warx@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by warx@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
achuith@chromium.org changed reviewers: + achuith@chromium.org
The CQ bit was checked by achuith@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1487756771605170, "parent_rev": "d7bd35142ea07f588ba2decdd4c184d68e34d35a", "commit_rev": "26f01531f9e0ecd2e0cde6cf5dacb0e4b70610ce"}
Message was sent while issue was closed.
Description was changed from ========== Revert of Signin screen and locked screen status area focus advancing (https://codereview.chromium.org/2295843006) Revert reason: Revert to get rid of the crash before having a proper fix. BUG=692784 BUG=468969 TEST=crash doesn't happen now, leaving the bug in crbug.com/468969 comment 7 reopen. ========== to ========== Revert of Signin screen and locked screen status area focus advancing (https://codereview.chromium.org/2295843006) Revert reason: Revert to get rid of the crash before having a proper fix. BUG=692784 BUG=468969 TEST=crash doesn't happen now, leaving the bug in crbug.com/468969 comment 7 reopen. Review-Url: https://codereview.chromium.org/2709593002 Cr-Commit-Position: refs/heads/master@{#451983} Committed: https://chromium.googlesource.com/chromium/src/+/26f01531f9e0ecd2e0cde6cf5dac... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/26f01531f9e0ecd2e0cde6cf5dac... |