Revert of 'Signin screen and locked screen status area focus advancing'

Revert of Signin screen and locked screen status area focus advancing (https://codereview.chromium.org/2295843006)

Revert reason:
Revert to get rid of the crash before having a proper fix.

BUG=692784
BUG=468969
TEST=crash doesn't happen now, leaving the bug in crbug.com/468969 comment 7 reopen.

Review-Url: https://codereview.chromium.org/2709593002
Cr-Commit-Position: refs/heads/master@{#451983}
Committed: https://chromium.googlesource.com/chromium/src/+/26f01531f9e0ecd2e0cde6cf5dacb0e4b70610ce

[Qiang(Joe) Xu, 2017-02-20 19:39:39]

The CQ bit was checked by warx@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 19:39:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 20:38:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 20:38:01]

Dry run: This issue passed the CQ dry run.

[Qiang(Joe) Xu, 2017-02-21 21:53:56]

Patchset #2 (id:20001) has been deleted

[Qiang(Joe) Xu, 2017-02-21 21:57:10]

Description was changed from

==========
cros: Fix the crash on tabbing through status area

BUG=692784
BUG=468969
==========

to

==========
cros: Fix the crash on tabbing through status area by reverting 2295843006

Changes:
Revert https://codereview.chromium.org/2295843006, as it causes crash.

BUG=692784
BUG=468969
TEST=crash doesn't happen now, leaving the bug in crbug.com/468969 comment 7
reopen.
==========

[Qiang(Joe) Xu, 2017-02-21 21:57:10]

warx@chromium.org changed reviewers:
+ stevenjb@chromium.org, xiyuan@chromium.org

[Qiang(Joe) Xu, 2017-02-21 22:00:23]

Hi all, ptal, thanks!

[xiyuan, 2017-02-21 22:04:32]

lgtm

I would say revert to get rid of the crash before having a proper fix, rather
than claiming fixing the crash. :p

[stevenjb, 2017-02-21 22:10:58]

On 2017/02/21 22:04:32, xiyuan wrote:
> lgtm
> 
> I would say revert to get rid of the crash before having a proper fix, rather
> than claiming fixing the crash. :p

Also, for clarity, the CL title should be 'Revert of Signin screen and locked
screen status area focus advancing (https://codereview.chromium.org/2295843006)'

Be sure to update the first line of the description too, and leave the 'Fix the
crash on ...' in the description as an explanation for the revert.

[Qiang(Joe) Xu, 2017-02-21 22:16:28]

Description was changed from

==========
cros: Fix the crash on tabbing through status area by reverting 2295843006

Changes:
Revert https://codereview.chromium.org/2295843006, as it causes crash.

BUG=692784
BUG=468969
TEST=crash doesn't happen now, leaving the bug in crbug.com/468969 comment 7
reopen.
==========

to

==========
Revert of Signin screen and locked screen status area focus advancing
(https://codereview.chromium.org/2295843006)'

Revert reason:
Revert to get rid of the crash before having a proper fix.

BUG=692784
BUG=468969
TEST=crash doesn't happen now, leaving the bug in crbug.com/468969 comment 7
reopen.
==========

[Qiang(Joe) Xu, 2017-02-21 22:16:45]

Description was changed from

==========
Revert of Signin screen and locked screen status area focus advancing
(https://codereview.chromium.org/2295843006)'

Revert reason:
Revert to get rid of the crash before having a proper fix.

BUG=692784
BUG=468969
TEST=crash doesn't happen now, leaving the bug in crbug.com/468969 comment 7
reopen.
==========

to

==========
Revert of Signin screen and locked screen status area focus advancing
(https://codereview.chromium.org/2295843006)

Revert reason:
Revert to get rid of the crash before having a proper fix.

BUG=692784
BUG=468969
TEST=crash doesn't happen now, leaving the bug in crbug.com/468969 comment 7
reopen.
==========

[Qiang(Joe) Xu, 2017-02-21 22:18:01]

On 2017/02/21 22:10:58, stevenjb wrote:
> On 2017/02/21 22:04:32, xiyuan wrote:
> > lgtm
> > 
> > I would say revert to get rid of the crash before having a proper fix,
rather
> > than claiming fixing the crash. :p
> 
> Also, for clarity, the CL title should be 'Revert of Signin screen and locked
> screen status area focus advancing
(https://codereview.chromium.org/2295843006)
> 
> Be sure to update the first line of the description too, and leave the 'Fix
the
> crash on ...' in the description as an explanation for the revert.

done, thanks. Oh, I probably should just click the revert button on the original
cl, right?

[stevenjb, 2017-02-21 22:19:02]

On 2017/02/21 22:18:01, Qiang(Joe) Xu wrote:
> On 2017/02/21 22:10:58, stevenjb wrote:
> > On 2017/02/21 22:04:32, xiyuan wrote:
> > > lgtm
> > > 
> > > I would say revert to get rid of the crash before having a proper fix,
> rather
> > > than claiming fixing the crash. :p
> > 
> > Also, for clarity, the CL title should be 'Revert of Signin screen and
locked
> > screen status area focus advancing
> (https://codereview.chromium.org/2295843006)
> > 
> > Be sure to update the first line of the description too, and leave the 'Fix
> the
> > crash on ...' in the description as an explanation for the revert.
> 
> done, thanks. Oh, I probably should just click the revert button on the
original
> cl, right?

That would work too :)

Either way, lgtm

[Qiang(Joe) Xu, 2017-02-21 22:20:00]

The CQ bit was checked by warx@chromium.org

[commit-bot: I haz the power, 2017-02-21 22:21:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 00:25:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 00:25:18]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[Qiang(Joe) Xu, 2017-02-22 00:27:21]

The CQ bit was checked by warx@chromium.org

[commit-bot: I haz the power, 2017-02-22 00:28:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 01:16:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 01:16:45]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[achuithb, 2017-02-22 09:46:11]

achuith@chromium.org changed reviewers:
+ achuith@chromium.org

[achuithb, 2017-02-22 09:46:11]

The CQ bit was checked by achuith@chromium.org

[achuithb, 2017-02-22 09:46:12]

lgtm

[commit-bot: I haz the power, 2017-02-22 09:47:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 10:44:15]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487756771605170, "parent_rev":
"d7bd35142ea07f588ba2decdd4c184d68e34d35a", "commit_rev":
"26f01531f9e0ecd2e0cde6cf5dacb0e4b70610ce"}

[commit-bot: I haz the power, 2017-02-22 10:44:53]

Description was changed from

==========
Revert of Signin screen and locked screen status area focus advancing
(https://codereview.chromium.org/2295843006)

Revert reason:
Revert to get rid of the crash before having a proper fix.

BUG=692784
BUG=468969
TEST=crash doesn't happen now, leaving the bug in crbug.com/468969 comment 7
reopen.
==========

to

==========
Revert of Signin screen and locked screen status area focus advancing
(https://codereview.chromium.org/2295843006)

Revert reason:
Revert to get rid of the crash before having a proper fix.

BUG=692784
BUG=468969
TEST=crash doesn't happen now, leaving the bug in crbug.com/468969 comment 7
reopen.

Review-Url: https://codereview.chromium.org/2709593002
Cr-Commit-Position: refs/heads/master@{#451983}
Committed:
https://chromium.googlesource.com/chromium/src/+/26f01531f9e0ecd2e0cde6cf5dac...
==========

[commit-bot: I haz the power, 2017-02-22 10:44:54]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/26f01531f9e0ecd2e0cde6cf5dac...