Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 2709523006: Rename AudioMixer factory method. (Closed)

Created:
3 years, 10 months ago by aleloi
Modified:
3 years, 10 months ago
Reviewers:
the sun
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, aleloi, hlundin-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Rename AudioMixer factory method. AudioMixerImpl::CreateWithOutputRateCalculatorAndLimiter(rate_calculator, bool limiter) was added to create a mixer without the limiter subcomponent. Calling it "Create with ... *and* limiter" is counterintuitive. Renamed to simply 'Create'. TBR=solenberg@webrtc.org BUG=webrtc:7167 Review-Url: https://codereview.webrtc.org/2709523006 Cr-Commit-Position: refs/heads/master@{#16755} Committed: https://chromium.googlesource.com/external/webrtc/+/087613c8df993e7facf98227cb267eaa0d5b1bbd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -25 lines) Patch
M webrtc/modules/audio_mixer/audio_mixer_impl.h View 1 chunk +2 lines, -3 lines 0 comments Download
M webrtc/modules/audio_mixer/audio_mixer_impl.cc View 1 chunk +5 lines, -8 lines 0 comments Download
M webrtc/modules/audio_mixer/audio_mixer_impl_unittest.cc View 5 chunks +17 lines, -14 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
aleloi
3 years, 10 months ago (2017-02-21 15:03:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2709523006/1
3 years, 10 months ago (2017-02-21 15:03:35 UTC) #5
the sun
lgtm
3 years, 10 months ago (2017-02-21 15:10:00 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-21 16:27:12 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/087613c8df993e7facf98227c...

Powered by Google App Engine
This is Rietveld 408576698