Minor changes in videoprocessor and videoprocessor_integrationtests.h

Minor changes in videoprocessor and videoprocessor_integrationtests.h

BUG=webrtc:6634
Review-Url: https://codereview.webrtc.org/2708993005
Cr-Commit-Position: refs/heads/master@{#17083}
Committed: https://chromium.googlesource.com/external/webrtc/+/ae9ba047c44a9aa295c61a666683a601b0cee8bd

[åsapersson, 2017-02-27 10:48:35]

The CQ bit was checked by asapersson@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 10:48:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-27 11:06:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 11:06:08]

Dry run: This issue passed the CQ dry run.

[åsapersson, 2017-02-27 11:22:30]

Patchset #4 (id:60001) has been deleted

[åsapersson, 2017-02-27 11:23:46]

Patchset #1 (id:1) has been deleted

[åsapersson, 2017-02-27 11:24:12]

Patchset #1 (id:20001) has been deleted

[åsapersson, 2017-02-28 14:23:25]

Description was changed from

==========
Change VerifyRateControl function...

BUG=webrtc:6634
==========

to

==========
Minor changes in videoprocessor and videoprocessor_integrationtests.h

BUG=webrtc:6634
==========

[åsapersson, 2017-02-28 14:23:25]

asapersson@webrtc.org changed reviewers:
+ brandtr@webrtc.org

[brandtr, 2017-02-28 15:34:56]

Nice cleanup!

lgtm, with a small request.

https://codereview.webrtc.org/2708993005/diff/80001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h
(right):

https://codereview.webrtc.org/2708993005/diff/80001/webrtc/modules/video_codi...
webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h:482:
layer_ = 0;
While you're at it, could you remove |layer_| and have this function return
|layer| instead? That's what I'm doing here:
https://codereview.webrtc.org/2707023008/diff/20001/webrtc/modules/video_codi...,
and if you do it in this CL instead, rebasing my CL will be easier :)

Another change could be to pass in |num_temporal_layers| as an argument, and
then this function could be made static. Not sure if that is cleaner though, so
it's up to you.

[åsapersson, 2017-02-28 16:01:56]

asapersson@webrtc.org changed reviewers:
+ sprang@webrtc.org

[åsapersson, 2017-02-28 16:01:57]

+sprang

https://codereview.webrtc.org/2708993005/diff/80001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h
(right):

https://codereview.webrtc.org/2708993005/diff/80001/webrtc/modules/video_codi...
webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h:482:
layer_ = 0;
On 2017/02/28 15:34:56, brandtr wrote:
> While you're at it, could you remove |layer_| and have this function return
> |layer| instead? That's what I'm doing here:
>
https://codereview.webrtc.org/2707023008/diff/20001/webrtc/modules/video_codi...,
> and if you do it in this CL instead, rebasing my CL will be easier :)
> 
> Another change could be to pass in |num_temporal_layers| as an argument, and
> then this function could be made static. Not sure if that is cleaner though,
so
> it's up to you.

Done.

[sprang_webrtc, 2017-03-06 17:24:52]

sorry, I dropped the ball here
lgtm

[åsapersson, 2017-03-07 07:36:14]

The CQ bit was checked by asapersson@webrtc.org

[åsapersson, 2017-03-07 07:36:14]

The patchset sent to the CQ was uploaded after l-g-t-m from brandtr@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2708993005/#ps100001 (title:
"address comment")

[commit-bot: I haz the power, 2017-03-07 07:36:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-07 07:37:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 07:37:49]

Try jobs failed on following builders:
  ios_api_framework on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_api_framework/build...)
  ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/18302)
  ios_arm64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/18113)
  ios_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/22359)
  linux_libfuzzer_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_libfuzzer_rel/bui...)
  mac_asan on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_asan/builds/22715)
  mac_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/19575)
  mac_compile_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_compile_dbg/builds/...)
  mac_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/23569)

[åsapersson, 2017-03-07 07:50:56]

The CQ bit was checked by asapersson@webrtc.org

[åsapersson, 2017-03-07 07:50:56]

The patchset sent to the CQ was uploaded after l-g-t-m from brandtr@webrtc.org,
sprang@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2708993005/#ps120001 (title:
"rebase")

[commit-bot: I haz the power, 2017-03-07 07:50:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-07 08:25:39]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1488873056522330,
"parent_rev": "c438bb169738d8f76143f4fb323316ec2e6211e9", "commit_rev":
"ae9ba047c44a9aa295c61a666683a601b0cee8bd"}

[commit-bot: I haz the power, 2017-03-07 08:25:42]

Description was changed from

==========
Minor changes in videoprocessor and videoprocessor_integrationtests.h

BUG=webrtc:6634
==========

to

==========
Minor changes in videoprocessor and videoprocessor_integrationtests.h

BUG=webrtc:6634

Review-Url: https://codereview.webrtc.org/2708993005
Cr-Commit-Position: refs/heads/master@{#17083}
Committed:
https://chromium.googlesource.com/external/webrtc/+/ae9ba047c44a9aa295c61a666...
==========

[commit-bot: I haz the power, 2017-03-07 08:25:43]

Committed patchset #4 (id:120001) as
https://chromium.googlesource.com/external/webrtc/+/ae9ba047c44a9aa295c61a666...