Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2708373005: Fix compilation issue detected by internal tool. (Closed)

Created:
3 years, 10 months ago by aleloi
Modified:
3 years, 10 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, aleloi, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix compilation issue detected by internal tool. Explicit initialization of const member of new EchoCanceller 3 submodule. Same thing as f3e84717 from https://codereview.webrtc.org/2715573003, but more of it. This should be the last one. TBR=henrik.lundin@webrtc.org NOTRY=True BUG=webrtc:6018 Review-Url: https://codereview.webrtc.org/2708373005 Cr-Commit-Position: refs/heads/master@{#16804} Committed: https://chromium.googlesource.com/external/webrtc/+/88b82b59f185e9cdc8425be228e3879ba152a83b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M webrtc/modules/audio_processing/aec3/echo_remover.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/aec3/subtractor.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/aec3/suppression_filter.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
aleloi
3 years, 10 months ago (2017-02-23 14:24:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2708373005/1
3 years, 10 months ago (2017-02-23 14:24:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/88b82b59f185e9cdc8425be228e3879ba152a83b
3 years, 10 months ago (2017-02-23 14:27:07 UTC) #8
hlundin-webrtc
3 years, 10 months ago (2017-02-23 14:30:54 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698