Add support for priorities to TaskQueue.

Add support for priorities to TaskQueue.

BUG=webrtc:7216
Review-Url: https://codereview.webrtc.org/2708353003
Cr-Commit-Position: refs/heads/master@{#16834}
Committed: https://chromium.googlesource.com/external/webrtc/+/c9bb7918f6c3dec9b3d583bbf2fc53e74ea875b6

[tommi, 2017-02-22 22:03:55]

tommi@webrtc.org changed reviewers:
+ solenberg@webrtc.org

[tommi, 2017-02-22 22:03:56]

Hey Fredrik - sorry, one more CL coming your way :)

[tommi, 2017-02-22 22:04:01]

The CQ bit was checked by tommi@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 22:04:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[tommi, 2017-02-22 22:06:07]

https://codereview.webrtc.org/2708353003/diff/1/webrtc/base/task_queue_win.cc
File webrtc/base/task_queue_win.cc (right):

https://codereview.webrtc.org/2708353003/diff/1/webrtc/base/task_queue_win.cc...
webrtc/base/task_queue_win.cc:63: return kNormalPriority;
ms compiler would complain unless I had a return statement

[commit-bot: I haz the power, 2017-02-22 22:53:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 22:53:23]

Dry run: This issue passed the CQ dry run.

[tommi, 2017-02-23 08:43:04]

Rebase

[tommi, 2017-02-23 11:18:49]

The CQ bit was checked by tommi@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 11:18:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-23 11:57:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 11:57:25]

Dry run: This issue passed the CQ dry run.

[tommi, 2017-02-24 06:34:45]

pling

[the sun, 2017-02-24 08:48:35]

On 2017/02/24 06:34:45, tommi (webrtc) wrote:
> pling

Sorry about the latency; TALN

[the sun, 2017-02-24 09:03:44]

lgtm % nits

https://codereview.webrtc.org/2708353003/diff/20001/webrtc/base/task_queue.h
File webrtc/base/task_queue.h (left):

https://codereview.webrtc.org/2708353003/diff/20001/webrtc/base/task_queue.h#...
webrtc/base/task_queue.h:165: // TODO(tommi): Implement move semantics?
Did you mean to remove comment? (FYI: Move semantics on the queue doesn't make a
whole lot of sense to me.)

https://codereview.webrtc.org/2708353003/diff/20001/webrtc/base/task_queue.h
File webrtc/base/task_queue.h (right):

https://codereview.webrtc.org/2708353003/diff/20001/webrtc/base/task_queue.h#...
webrtc/base/task_queue.h:166: enum Priority {
We can use enum class these days

https://codereview.webrtc.org/2708353003/diff/20001/webrtc/base/task_queue_li...
File webrtc/base/task_queue_libevent.cc (right):

https://codereview.webrtc.org/2708353003/diff/20001/webrtc/base/task_queue_li...
webrtc/base/task_queue_libevent.cc:95: default:
If compiler won't warn about an unhandled "case", you should instead of silently
resorting to default:

...
case TaskQueue::NORMAL:
  return kNormalPriority;
default:
  RTC_NOTREACHED();
  return kNormalPriority;
...

[tommi, 2017-02-24 17:34:29]

Address comments

[tommi, 2017-02-24 17:34:41]

https://codereview.webrtc.org/2708353003/diff/20001/webrtc/base/task_queue.h
File webrtc/base/task_queue.h (left):

https://codereview.webrtc.org/2708353003/diff/20001/webrtc/base/task_queue.h#...
webrtc/base/task_queue.h:165: // TODO(tommi): Implement move semantics?
On 2017/02/24 09:03:43, the sun wrote:
> Did you mean to remove comment? (FYI: Move semantics on the queue doesn't make
a
> whole lot of sense to me.)

Yeah that's why I removed it. If we find we need it, we can do it but it didn't
feel like this was still worth a todo. besides, the todo had a question mark, so
maybe 'no' is a fine answer and the todo is done :D

https://codereview.webrtc.org/2708353003/diff/20001/webrtc/base/task_queue.h
File webrtc/base/task_queue.h (right):

https://codereview.webrtc.org/2708353003/diff/20001/webrtc/base/task_queue.h#...
webrtc/base/task_queue.h:166: enum Priority {
On 2017/02/24 09:03:43, the sun wrote:
> We can use enum class these days

oooh! completely forgot - Done!

https://codereview.webrtc.org/2708353003/diff/20001/webrtc/base/task_queue_li...
File webrtc/base/task_queue_libevent.cc (right):

https://codereview.webrtc.org/2708353003/diff/20001/webrtc/base/task_queue_li...
webrtc/base/task_queue_libevent.cc:95: default:
On 2017/02/24 09:03:43, the sun wrote:
> If compiler won't warn about an unhandled "case", you should instead of
silently
> resorting to default:
> 
> ...
> case TaskQueue::NORMAL:
>   return kNormalPriority;
> default:
>   RTC_NOTREACHED();
>   return kNormalPriority;
> ...

Done.

[tommi, 2017-02-24 17:35:12]

The CQ bit was checked by tommi@webrtc.org

[tommi, 2017-02-24 17:35:12]

The patchset sent to the CQ was uploaded after l-g-t-m from solenberg@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2708353003/#ps40001 (title:
"Address comments")

[commit-bot: I haz the power, 2017-02-24 17:35:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-24 18:42:14]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487957712609320,
"parent_rev": "3ba1a8cd1b875dc7bfcb7075fe4f78d0dfe0ff98", "commit_rev":
"c9bb7918f6c3dec9b3d583bbf2fc53e74ea875b6"}

[commit-bot: I haz the power, 2017-02-24 18:42:17]

Description was changed from

==========
Add support for priorities to TaskQueue.

BUG=webrtc:7216
==========

to

==========
Add support for priorities to TaskQueue.

BUG=webrtc:7216

Review-Url: https://codereview.webrtc.org/2708353003
Cr-Commit-Position: refs/heads/master@{#16834}
Committed:
https://chromium.googlesource.com/external/webrtc/+/c9bb7918f6c3dec9b3d583bbf...
==========

[commit-bot: I haz the power, 2017-02-24 18:42:18]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/c9bb7918f6c3dec9b3d583bbf...