Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 2707843002: Remove uses of #pragma once and add PRESUBMIT check. (Closed)

Created:
3 years, 10 months ago by kjellander_webrtc
Modified:
3 years, 10 months ago
Reviewers:
henrika_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove uses of #pragma once and add PRESUBMIT check. They violate the C++ coding style guide: https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md#File-headers BUG=webrtc:7191 NOTRY=True Review-Url: https://codereview.webrtc.org/2707843002 Cr-Commit-Position: refs/heads/master@{#16712} Committed: https://chromium.googlesource.com/external/webrtc/+/6aeef74b6e04bfa78a90b38b5d2323b24f0875d2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -8 lines) Patch
M PRESUBMIT.py View 2 chunks +21 lines, -0 lines 0 comments Download
M webrtc/examples/peerconnection/client/conductor.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/examples/peerconnection/client/defaults.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/examples/peerconnection/client/flagdefs.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/examples/peerconnection/client/main_wnd.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/examples/peerconnection/client/peer_connection_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/examples/peerconnection/server/data_socket.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/examples/peerconnection/server/peer_channel.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/examples/peerconnection/server/utils.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
kjellander_webrtc
3 years, 10 months ago (2017-02-20 08:50:26 UTC) #3
kjellander_webrtc
FYI the check is plain copy of Chromium's: https://cs.chromium.org/chromium/src/PRESUBMIT.py?rcl=22f522e10dd7a816ec45547fd35a6fa0356b3d21&l=640
3 years, 10 months ago (2017-02-20 08:51:48 UTC) #4
henrika_webrtc
LGTM
3 years, 10 months ago (2017-02-20 09:05:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2707843002/1
3 years, 10 months ago (2017-02-20 09:10:43 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 09:13:22 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/6aeef74b6e04bfa78a90b38b5...

Powered by Google App Engine
This is Rietveld 408576698