Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2707763005:
Remove codec setting members in VideoProcessorIntegrationTest. Use settings in CodecConfigPars dire… (Closed)
|
Created:
3 years, 10 months ago by åsapersson Modified:
3 years, 10 months ago CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionRemove codec setting members in VideoProcessorIntegrationTest. Use settings in CodecConfigPars directly instead.
BUG=webrtc:6634
Review-Url: https://codereview.webrtc.org/2707763005
Cr-Commit-Position: refs/heads/master@{#16764}
Committed: https://chromium.googlesource.com/external/webrtc/+/59fc9030ea86656f8bf1135b56dced3917df4a1c
Patch Set 1 #Patch Set 2 : rebase #Patch Set 3 : rebase #
Total comments: 4
Patch Set 4 : address comments #Patch Set 5 : rebase #Patch Set 6 #Messages
Total messages: 22 (16 generated)
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Description was changed from ========== Remove codec setting members in VideoProcessorIntegrationTest. Use settings in CodecConfigPars directly instead. BUG=webrtc:6634 ========== to ========== Remove codec setting members in VideoProcessorIntegrationTest. Use settings in CodecConfigPars directly instead. BUG=webrtc:6634 ==========
asapersson@webrtc.org changed reviewers: + brandtr@webrtc.org, sprang@webrtc.org
Nice cleanup! lgtm
lgtm with nit https://codereview.webrtc.org/2707763005/diff/80001/webrtc/modules/video_codi... File webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h (right): https://codereview.webrtc.org/2707763005/diff/80001/webrtc/modules/video_codi... webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h:153: if (process.codec_type == kVideoCodecH264) { While you're here, can you switch (ehm) this to a switch statement instead of if/else? https://codereview.webrtc.org/2707763005/diff/80001/webrtc/modules/video_codi... webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h:183: if (process.codec_type == kVideoCodecH264) { dito
https://codereview.webrtc.org/2707763005/diff/80001/webrtc/modules/video_codi... File webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h (right): https://codereview.webrtc.org/2707763005/diff/80001/webrtc/modules/video_codi... webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h:153: if (process.codec_type == kVideoCodecH264) { On 2017/02/21 15:21:35, språng wrote: > While you're here, can you switch (ehm) this to a switch statement instead of > if/else? Done. https://codereview.webrtc.org/2707763005/diff/80001/webrtc/modules/video_codi... webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h:183: if (process.codec_type == kVideoCodecH264) { On 2017/02/21 15:21:35, språng wrote: > dito Done.
The CQ bit was checked by asapersson@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...) android_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/21613)
The CQ bit was checked by asapersson@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by asapersson@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from brandtr@webrtc.org, sprang@webrtc.org Link to the patchset: https://codereview.webrtc.org/2707763005/#ps140001 (title: "")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 140001, "attempt_start_ts": 1487749491027710,
"parent_rev": "9ee5b3b0a71acf3266afe4998043851256c6cbc3", "commit_rev":
"59fc9030ea86656f8bf1135b56dced3917df4a1c"}
Message was sent while issue was closed.
Description was changed from ========== Remove codec setting members in VideoProcessorIntegrationTest. Use settings in CodecConfigPars directly instead. BUG=webrtc:6634 ========== to ========== Remove codec setting members in VideoProcessorIntegrationTest. Use settings in CodecConfigPars directly instead. BUG=webrtc:6634 Review-Url: https://codereview.webrtc.org/2707763005 Cr-Commit-Position: refs/heads/master@{#16764} Committed: https://chromium.googlesource.com/external/webrtc/+/59fc9030ea86656f8bf1135b5... ==========
Message was sent while issue was closed.
Committed patchset #6 (id:140001) as https://chromium.googlesource.com/external/webrtc/+/59fc9030ea86656f8bf1135b5... |
