Rename ReceiveInfo to TmmbrInfo

Rename ReceiveInfo to TmmbrInfo
together with related functions and variables
to stress it is used for Tmmbr only.

This is explicitly pure rename CL with no functional changes.

BUG=webrtc:5565
Review-Url: https://codereview.webrtc.org/2707763004
Cr-Commit-Position: refs/heads/master@{#16720}
Committed: https://chromium.googlesource.com/external/webrtc/+/9bf610ea8c09ad66785988e3277acb03c8224736

[danilchap, 2017-02-20 10:36:19]

Description was changed from

==========
Rename ReceiveInfo to TmmbrInfo
together with related functions and variables
to stress it is used for TmmbrOnly.

This is explicetly pure rename CL with no functional changes.

BUG=webrtc:5565
==========

to

==========
Rename ReceiveInfo to TmmbrInfo
together with related functions and variables
to stress it is used for Tmmbr only.

This is explicitly pure rename CL with no functional changes.

BUG=webrtc:5565
==========

[danilchap, 2017-02-20 10:44:29]

danilchap@webrtc.org changed reviewers:
+ nisse@webrtc.org

[nisse-webrtc, 2017-02-20 12:28:20]

https://codereview.webrtc.org/2707763004/diff/20001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc (right):

https://codereview.webrtc.org/2707763004/diff/20001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc:76: struct
RTCPReceiver::TmmbrInformation {
I'm a bit confused about the context here... Can you add a comment briefly
explaining what "tmmbr" is and/or point to the relevant spec?

https://codereview.webrtc.org/2707763004/diff/20001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc:78: rtcp::TmmbItem tmmbr_item;
Is it intentional that the type is TmmbItem and not TmmbrItem? All other names
seem to include the "r".

[danilchap, 2017-02-20 12:44:42]

https://codereview.webrtc.org/2707763004/diff/20001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc (right):

https://codereview.webrtc.org/2707763004/diff/20001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc:76: struct
RTCPReceiver::TmmbrInformation {
On 2017/02/20 12:28:20, nisse-webrtc wrote:
> I'm a bit confused about the context here... Can you add a comment briefly
> explaining what "tmmbr" is and/or point to the relevant spec?

Done.

https://codereview.webrtc.org/2707763004/diff/20001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc:78: rtcp::TmmbItem tmmbr_item;
On 2017/02/20 12:28:20, nisse-webrtc wrote:
> Is it intentional that the type is TmmbItem and not TmmbrItem? All other names
> seem to include the "r".

yes, because it is part of both
TMMBR (Temporary Maximum Media stream Bitrate Request)
and 
TMMBN (Temporary Maximum Media stream Bitrate Notification)
(there is a comment in rtcp_packet/tmmb_item.h)

tmmbr is more common prefix since everything else (including TMMBN) should be
one way or another respond to requests (TMMBRs)

[nisse-webrtc, 2017-02-20 12:46:40]

lgtm

[danilchap, 2017-02-20 13:00:16]

The CQ bit was checked by danilchap@webrtc.org

[commit-bot: I haz the power, 2017-02-20 13:00:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-20 14:03:01]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487595616344680,
"parent_rev": "424e6cfd589e0cdbfc9a664644dd1867271245f7", "commit_rev":
"9bf610ea8c09ad66785988e3277acb03c8224736"}

[commit-bot: I haz the power, 2017-02-20 14:03:04]

Description was changed from

==========
Rename ReceiveInfo to TmmbrInfo
together with related functions and variables
to stress it is used for Tmmbr only.

This is explicitly pure rename CL with no functional changes.

BUG=webrtc:5565
==========

to

==========
Rename ReceiveInfo to TmmbrInfo
together with related functions and variables
to stress it is used for Tmmbr only.

This is explicitly pure rename CL with no functional changes.

BUG=webrtc:5565

Review-Url: https://codereview.webrtc.org/2707763004
Cr-Commit-Position: refs/heads/master@{#16720}
Committed:
https://chromium.googlesource.com/external/webrtc/+/9bf610ea8c09ad66785988e32...
==========

[commit-bot: I haz the power, 2017-02-20 14:03:06]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/9bf610ea8c09ad66785988e32...