Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2707763004: Rename ReceiveInfo to TmmbrInfo (Closed)

Created:
3 years, 10 months ago by danilchap
Modified:
3 years, 10 months ago
Reviewers:
nisse-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Rename ReceiveInfo to TmmbrInfo together with related functions and variables to stress it is used for Tmmbr only. This is explicitly pure rename CL with no functional changes. BUG=webrtc:5565 Review-Url: https://codereview.webrtc.org/2707763004 Cr-Commit-Position: refs/heads/master@{#16720} Committed: https://chromium.googlesource.com/external/webrtc/+/9bf610ea8c09ad66785988e3277acb03c8224736

Patch Set 1 #

Patch Set 2 : tune comments #

Total comments: 4

Patch Set 3 : +comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -57 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtcp_receiver.h View 1 3 chunks +12 lines, -13 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc View 1 2 13 chunks +39 lines, -41 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
danilchap
3 years, 10 months ago (2017-02-20 10:44:30 UTC) #3
nisse-webrtc
https://codereview.webrtc.org/2707763004/diff/20001/webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc File webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc (right): https://codereview.webrtc.org/2707763004/diff/20001/webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc#newcode76 webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc:76: struct RTCPReceiver::TmmbrInformation { I'm a bit confused about the ...
3 years, 10 months ago (2017-02-20 12:28:20 UTC) #4
danilchap
https://codereview.webrtc.org/2707763004/diff/20001/webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc File webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc (right): https://codereview.webrtc.org/2707763004/diff/20001/webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc#newcode76 webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc:76: struct RTCPReceiver::TmmbrInformation { On 2017/02/20 12:28:20, nisse-webrtc wrote: > ...
3 years, 10 months ago (2017-02-20 12:44:42 UTC) #5
nisse-webrtc
lgtm
3 years, 10 months ago (2017-02-20 12:46:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2707763004/40001
3 years, 10 months ago (2017-02-20 13:00:27 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 14:03:06 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/9bf610ea8c09ad66785988e32...

Powered by Google App Engine
This is Rietveld 408576698