Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2707013005: Adding placeholder ortc_unittests target. (Closed)

Created:
3 years, 10 months ago by Taylor Brandstetter
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adding placeholder ortc_unittests target. This will allow the trybots to be updated to start running this new test executable, so that they can be used when landing this CL which will replace the dummy test with real tests: https://codereview.webrtc.org/2675173003/ BUG=webrtc:7013 TBR=tommi@webrtc.org Review-Url: https://codereview.webrtc.org/2707013005 Cr-Commit-Position: refs/heads/master@{#16784} Committed: https://chromium.googlesource.com/external/webrtc/+/4b1bf6c2f02e4be5a81965b125e7472a7dc8dff2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -0 lines) Patch
M webrtc/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A webrtc/ortc/BUILD.gn View 1 chunk +31 lines, -0 lines 0 comments Download
A webrtc/ortc/dummy_test.cc View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
Taylor Brandstetter
3 years, 10 months ago (2017-02-23 05:49:13 UTC) #4
kjellander_webrtc
lgtm
3 years, 10 months ago (2017-02-23 07:18:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2707013005/1
3 years, 10 months ago (2017-02-23 07:18:17 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/13922)
3 years, 10 months ago (2017-02-23 07:23:29 UTC) #11
kjellander_webrtc
TBR'ing tommi@ for the creation of the webrtc/ortc folder.
3 years, 10 months ago (2017-02-23 07:42:55 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2707013005/1
3 years, 10 months ago (2017-02-23 07:43:03 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/4b1bf6c2f02e4be5a81965b125e7472a7dc8dff2
3 years, 10 months ago (2017-02-23 07:45:42 UTC) #19
tommi
3 years, 10 months ago (2017-02-23 07:54:02 UTC) #20
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698