Fix clang style warnings in webrtc/base/thread.h

Fix clang style warnings in webrtc/base/thread.h

TBR=tommi@webrtc.org
BUG=webrtc:163
NOTRY=True # trivial change, last round of tests passed.

Review-Url: https://codereview.webrtc.org/2706843002
Cr-Commit-Position: refs/heads/master@{#16715}
Committed: https://chromium.googlesource.com/external/webrtc/+/8dd4ec3324215aee19a58c4d050175bb93af1948

[aleloi, 2017-02-20 11:08:20]

The CQ bit was checked by aleloi@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 11:08:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-20 11:14:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 11:14:33]

Dry run: Try jobs failed on following builders:
  win_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_rel/builds/23424)
  win_x64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_dbg/builds/6481)

[aleloi, 2017-02-20 11:30:32]

The CQ bit was checked by aleloi@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 11:30:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[aleloi, 2017-02-20 12:02:58]

The CQ bit was unchecked by aleloi@webrtc.org

[aleloi, 2017-02-20 12:03:07]

The CQ bit was checked by aleloi@webrtc.org

[commit-bot: I haz the power, 2017-02-20 12:03:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[tommi, 2017-02-20 12:12:00]

lgtm
btw, when tbr-ing changes, please send out the review request. I just noticed
this because of the notification sent from the commit-bot.

[tommi, 2017-02-20 12:13:08]

(one nit)

https://codereview.webrtc.org/2706843002/diff/60001/webrtc/base/thread.cc
File webrtc/base/thread.cc (right):

https://codereview.webrtc.org/2706843002/diff/60001/webrtc/base/thread.cc#new...
webrtc/base/thread.cc:575: ComThread::~ComThread() {
nit: methods in the .cc file should be in the same order as in the .h file.

[aleloi, 2017-02-20 12:13:11]

On 2017/02/20 12:12:00, tommi (webrtc) wrote:
> lgtm
> btw, when tbr-ing changes, please send out the review request. I just noticed
> this because of the notification sent from the commit-bot.

Ok, thx!

[aleloi, 2017-02-20 12:13:30]

The CQ bit was unchecked by aleloi@webrtc.org

[aleloi, 2017-02-20 12:15:04]

Description was changed from

==========
Fix clang style warnings in webrtc/base/thread.h

TBR=tommi@webrtc.org
BUG=webrtc:163
==========

to

==========
Fix clang style warnings in webrtc/base/thread.h

TBR=tommi@webrtc.org
BUG=webrtc:163
NOTRY=True # trivial change, last round of tests passed.
==========

[aleloi, 2017-02-20 12:15:14]

The CQ bit was checked by aleloi@webrtc.org

[aleloi, 2017-02-20 12:15:14]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2706843002/#ps80001 (title:
"Reordering methods.")

[commit-bot: I haz the power, 2017-02-20 12:15:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-20 12:17:54]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1487592914077810,
"parent_rev": "9420af79002d0e580c4391fef1ca4ee909c6989d", "commit_rev":
"8dd4ec3324215aee19a58c4d050175bb93af1948"}

[commit-bot: I haz the power, 2017-02-20 12:17:56]

Description was changed from

==========
Fix clang style warnings in webrtc/base/thread.h

TBR=tommi@webrtc.org
BUG=webrtc:163
NOTRY=True # trivial change, last round of tests passed.
==========

to

==========
Fix clang style warnings in webrtc/base/thread.h

TBR=tommi@webrtc.org
BUG=webrtc:163
NOTRY=True # trivial change, last round of tests passed.

Review-Url: https://codereview.webrtc.org/2706843002
Cr-Commit-Position: refs/heads/master@{#16715}
Committed:
https://chromium.googlesource.com/external/webrtc/+/8dd4ec3324215aee19a58c4d0...
==========

[commit-bot: I haz the power, 2017-02-20 12:17:57]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/external/webrtc/+/8dd4ec3324215aee19a58c4d0...