Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 2706823002: Added GetCpuTime to base/ to get total CPU time consumed by process for perf tests. (Closed)

Created:
3 years, 10 months ago by ilnik
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Added GetCpuTime to base/ to get total CPU time consumed by process for perf tests. BUG=webrtc:7095 Review-Url: https://codereview.webrtc.org/2695743003 Cr-Commit-Position: refs/heads/master@{#16665} Committed: https://chromium.googlesource.com/external/webrtc/+/3ff474b72ba1b34027e8391b1014c2838af445d4 patch from issue 2695743003 at patchset 440001 (http://crrev.com/2695743003#ps440001) Review-Url: https://codereview.webrtc.org/2706823002 Cr-Commit-Position: refs/heads/master@{#16736} Committed: https://chromium.googlesource.com/external/webrtc/+/531100dc7a9c58d8cbe200cf3a65d1254070861d

Patch Set 1 #

Patch Set 2 : moving cpu_time.cc to rtc_base_tests_utils #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+253 lines, -0 lines) Patch
M webrtc/base/BUILD.gn View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
A webrtc/base/cpu_time.h View 1 chunk +28 lines, -0 lines 0 comments Download
A webrtc/base/cpu_time.cc View 1 chunk +114 lines, -0 lines 0 comments Download
A webrtc/base/cpu_time_unittest.cc View 1 chunk +108 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (14 generated)
ilnik
This is a fix for https://codereview.webrtc.org/2695743003/. Now Build.gn is updated so unittest is in the ...
3 years, 10 months ago (2017-02-20 10:06:23 UTC) #2
ilnik
3 years, 10 months ago (2017-02-20 12:29:19 UTC) #3
ilnik
This issue is ready for review. Now cpu_time_unittest is in the nonparallel test source set.
3 years, 10 months ago (2017-02-20 12:30:03 UTC) #4
Taylor Brandstetter
Assuming the BUILD.gn change is the only change, lgtm. I'd also recommend updating the description ...
3 years, 10 months ago (2017-02-20 20:26:51 UTC) #9
ilnik
On 2017/02/20 20:26:51, Taylor Brandstetter wrote: > Assuming the BUILD.gn change is the only change, ...
3 years, 10 months ago (2017-02-21 08:44:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2706823002/20001
3 years, 10 months ago (2017-02-21 08:45:05 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/13800)
3 years, 10 months ago (2017-02-21 08:48:36 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2706823002/40001
3 years, 10 months ago (2017-02-21 09:01:35 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_clang_dbg on ...
3 years, 10 months ago (2017-02-21 11:02:16 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2706823002/40001
3 years, 10 months ago (2017-02-21 11:14:52 UTC) #22
commit-bot: I haz the power
3 years, 10 months ago (2017-02-21 11:33:29 UTC) #25
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/531100dc7a9c58d8cbe200cf3...

Powered by Google App Engine
This is Rietveld 408576698