Added memory usage function to base.

Added memory usage function to webrtc/base/.

BUG=webrtc:7095
Review-Url: https://codereview.webrtc.org/2706403010
Cr-Commit-Position: refs/heads/master@{#16895}
Committed: https://chromium.googlesource.com/external/webrtc/+/ab210c8ad96764ede65d6760a14189f3ac6f7f9d

[ilnik, 2017-02-23 15:59:50]

The CQ bit was checked by ilnik@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 15:59:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-23 16:02:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 16:02:37]

Dry run: Try jobs failed on following builders:
  ios_arm64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/17681)
  mac_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/19145)

[ilnik, 2017-02-23 16:05:39]

The CQ bit was checked by ilnik@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 16:05:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[ilnik, 2017-02-23 16:06:43]

The CQ bit was checked by ilnik@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 16:06:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[ilnik, 2017-02-23 16:06:52]

The CQ bit was unchecked by ilnik@webrtc.org

[ilnik, 2017-02-24 12:43:29]

Description was changed from

==========
Added memory usage function to base.

BUG=webrtc:7095
==========

to

==========
Added memory usage function to webrtc/base/.

BUG=webrtc:7095
==========

[ilnik, 2017-02-24 12:52:02]

ilnik@webrtc.org changed reviewers:
+ deadbeef@webrtc.org, sprang@webrtc.org

[ilnik, 2017-02-24 13:13:03]

The CQ bit was checked by ilnik@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 13:13:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-24 14:27:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 14:27:06]

Dry run: This issue passed the CQ dry run.

[Taylor Brandstetter, 2017-02-25 00:52:59]

https://codereview.webrtc.org/2706403010/diff/160001/webrtc/base/memory_usage.h
File webrtc/base/memory_usage.h (right):

https://codereview.webrtc.org/2706403010/diff/160001/webrtc/base/memory_usage...
webrtc/base/memory_usage.h:17: // Returns current memory used by the process in
bytes.
Could you add that this returns -1 on failure, and describe more precisely what
memory size is returned? Would that be "working set size, or resident size on
Linux/Mac"?

[ilnik, 2017-02-27 08:46:16]

https://codereview.webrtc.org/2706403010/diff/160001/webrtc/base/memory_usage.h
File webrtc/base/memory_usage.h (right):

https://codereview.webrtc.org/2706403010/diff/160001/webrtc/base/memory_usage...
webrtc/base/memory_usage.h:17: // Returns current memory used by the process in
bytes.
On 2017/02/25 00:52:59, Taylor Brandstetter wrote:
> Could you add that this returns -1 on failure, and describe more precisely
what
> memory size is returned? Would that be "working set size, or resident size on
> Linux/Mac"?

Done. Also changed the name of the function to better reflect it's nature.

[Taylor Brandstetter, 2017-02-27 21:51:22]

lgtm

[ilnik, 2017-02-28 08:33:23]

The CQ bit was checked by ilnik@webrtc.org

[commit-bot: I haz the power, 2017-02-28 08:33:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-28 08:55:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 08:55:03]

Try jobs failed on following builders:
  linux_tsan2 on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/20331)

[sprang_webrtc, 2017-02-28 08:58:42]

Could you please add unit test as well, just sanity testing that we get some
positive value for each platform?

[ilnik, 2017-02-28 09:18:14]

On 2017/02/28 08:58:42, språng wrote:
> Could you please add unit test as well, just sanity testing that we get some
> positive value for each platform?

Done.

[sprang_webrtc, 2017-02-28 09:32:09]

lgtm

[ilnik, 2017-02-28 09:32:46]

The CQ bit was checked by ilnik@webrtc.org

[ilnik, 2017-02-28 09:32:46]

The patchset sent to the CQ was uploaded after l-g-t-m from deadbeef@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2706403010/#ps220001 (title:
"Added simple unittest and rebased")

[commit-bot: I haz the power, 2017-02-28 09:32:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-28 10:18:28]

CQ is committing da patch.

Bot data: {"patchset_id": 220001, "attempt_start_ts": 1488274366266740,
"parent_rev": "322a9e42f8cd6652d1f8ed9324ae9429f27b74cd", "commit_rev":
"ab210c8ad96764ede65d6760a14189f3ac6f7f9d"}

[commit-bot: I haz the power, 2017-02-28 10:18:30]

Description was changed from

==========
Added memory usage function to webrtc/base/.

BUG=webrtc:7095
==========

to

==========
Added memory usage function to webrtc/base/.

BUG=webrtc:7095

Review-Url: https://codereview.webrtc.org/2706403010
Cr-Commit-Position: refs/heads/master@{#16895}
Committed:
https://chromium.googlesource.com/external/webrtc/+/ab210c8ad96764ede65d6760a...
==========

[commit-bot: I haz the power, 2017-02-28 10:18:32]

Committed patchset #12 (id:220001) as
https://chromium.googlesource.com/external/webrtc/+/ab210c8ad96764ede65d6760a...