Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2705613002: Rename some variables and methods in RTC event log. (Closed)

Created:
3 years, 10 months ago by terelius
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, zhuangzesen_agora.io, Andrew MacDonald, henrika_webrtc, stefan-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Rename some variables and methods in RTC event log. Rename loss based and delay based bwe updates in proto (and correspondingly in the C++ code). BUG=webrtc:6423 Review-Url: https://codereview.webrtc.org/2705613002 Cr-Commit-Position: refs/heads/master@{#16719} Committed: https://chromium.googlesource.com/external/webrtc/+/424e6cfd589e0cdbfc9a664644dd1867271245f7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -112 lines) Patch
M webrtc/logging/rtc_event_log/mock/mock_rtc_event_log.h View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log.h View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log.cc View 3 chunks +15 lines, -15 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log.proto View 5 chunks +10 lines, -10 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_parser.h View 3 chunks +6 lines, -6 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_parser.cc View 4 chunks +25 lines, -25 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_unittest.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_unittest_helper.cc View 6 chunks +21 lines, -21 lines 0 comments Download
M webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/bitrate_controller/send_side_bandwidth_estimation_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/congestion_controller/delay_based_bwe.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/tools/event_log_visualizer/analyzer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/tools/event_log_visualizer/analyzer.cc View 1 chunk +10 lines, -10 lines 0 comments Download
M webrtc/voice_engine/channel.cc View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
terelius
3 years, 10 months ago (2017-02-17 14:31:58 UTC) #4
philipel
lgtm
3 years, 10 months ago (2017-02-17 14:45:17 UTC) #5
terelius
+solenberg for voice_engine/
3 years, 10 months ago (2017-02-17 14:48:22 UTC) #7
the sun
lgtm for voice_engine
3 years, 10 months ago (2017-02-17 15:22:10 UTC) #8
stefan-webrtc
lgtm
3 years, 10 months ago (2017-02-20 12:33:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2705613002/1
3 years, 10 months ago (2017-02-20 12:34:27 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 13:14:46 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/424e6cfd589e0cdbfc9a66464...

Powered by Google App Engine
This is Rietveld 408576698