Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2705603003: Don't use CONF_VALUE in VerifyServerName. (Closed)

Created:
3 years, 10 months ago by davidben_webrtc
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Don't use CONF_VALUE in VerifyServerName. This does not fix the myriad of other problems here, but at least removes the dependency on CONF_VALUE. BUG=526270 Review-Url: https://codereview.webrtc.org/2705603003 Cr-Commit-Position: refs/heads/master@{#16676} Committed: https://chromium.googlesource.com/external/webrtc/+/4ef903d3db47e854b3290c35eb6f64ee1558e7d2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -53 lines) Patch
M webrtc/base/openssladapter.cc View 2 chunks +16 lines, -53 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
davidben_webrtc
3 years, 10 months ago (2017-02-17 20:14:16 UTC) #4
davidben_webrtc
3 years, 10 months ago (2017-02-17 20:32:27 UTC) #6
Ryan Sleevi
LGTM
3 years, 10 months ago (2017-02-17 20:34:01 UTC) #7
pthatcher1
lgtm
3 years, 10 months ago (2017-02-17 20:49:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2705603003/1
3 years, 10 months ago (2017-02-17 20:49:55 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 21:04:48 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/4ef903d3db47e854b3290c35e...

Powered by Google App Engine
This is Rietveld 408576698