Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2705203002: Implement operator<< for AudioCodec (Closed)

Created:
3 years, 10 months ago by kwiberg-webrtc
Modified:
3 years, 10 months ago
Reviewers:
ossu
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Implement operator<< for AudioCodec It's annoying to have to re-implement this every time I need a debug printout. Declared inline, so that there'll be zero runtime overhead. This CL also modifies a unit test so that it will make use of the new operator<< in case it finds errors. BUG=none Review-Url: https://codereview.webrtc.org/2705203002 Cr-Commit-Position: refs/heads/master@{#16749} Committed: https://chromium.googlesource.com/external/webrtc/+/b94491d7904feb9b072b1adaa9454c9615fba5f8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -15 lines) Patch
M webrtc/media/base/codec.h View 1 chunk +22 lines, -0 lines 0 comments Download
M webrtc/media/base/codec_unittest.cc View 2 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
kwiberg-webrtc
3 years, 10 months ago (2017-02-21 12:39:04 UTC) #4
ossu
LGTM. Good call!
3 years, 10 months ago (2017-02-21 13:57:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2705203002/1
3 years, 10 months ago (2017-02-21 14:13:47 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-21 14:16:22 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/b94491d7904feb9b072b1adaa...

Powered by Google App Engine
This is Rietveld 408576698