Remove ScopedVector from content/renderer/.

Remove ScopedVector from content/renderer/.

base::ScopedVector is deprecated, see bug.

BUG=554289
Review-Url: https://codereview.chromium.org/2705073003
Cr-Commit-Position: refs/heads/master@{#452388}
Committed: https://chromium.googlesource.com/chromium/src/+/21e0e489169ec98a36540905cf7c78ba907b7910

[leonhsl(Using Gerrit), 2017-02-21 07:15:14]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 07:15:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 07:57:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 07:57:08]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[leonhsl(Using Gerrit), 2017-02-21 08:20:52]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 08:21:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[leonhsl(Using Gerrit), 2017-02-21 08:34:47]

Patchset #1 (id:1) has been deleted

[leonhsl(Using Gerrit), 2017-02-21 08:35:07]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 08:35:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[leonhsl(Using Gerrit), 2017-02-21 08:35:37]

Patchset #1 (id:20001) has been deleted

[leonhsl(Using Gerrit), 2017-02-21 08:36:39]

leon.han@intel.com changed reviewers:
+ avi@chromium.org

[leonhsl(Using Gerrit), 2017-02-21 08:36:39]

PTAL, Thanks.

[commit-bot: I haz the power, 2017-02-21 09:49:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 09:49:05]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Avi (use Gerrit), 2017-02-21 16:01:36]

You have some Windows trybots to get green, but this is all very good work.
LGTM.

https://codereview.chromium.org/2705073003/diff/40001/content/renderer/histor...
File content/renderer/history_entry.h (right):

https://codereview.chromium.org/2705073003/diff/40001/content/renderer/histor...
content/renderer/history_entry.h:61: std::unique_ptr<HistoryNode>
CloneAndReplace(
👍

https://codereview.chromium.org/2705073003/diff/40001/content/renderer/pepper...
File content/renderer/pepper/pepper_video_decoder_host.cc (left):

https://codereview.chromium.org/2705073003/diff/40001/content/renderer/pepper...
content/renderer/pepper/pepper_video_decoder_host.cc:211: // the existing
element if we just assign over it.
Holy cow, this comment is correct. I thought that ScopedVector couldn't be that
bad, but yeah, it is. :(

[leonhsl(Using Gerrit), 2017-02-22 01:58:04]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 01:59:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[leonhsl(Using Gerrit), 2017-02-22 02:58:56]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 03:00:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 04:01:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 04:01:12]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[leonhsl(Using Gerrit), 2017-02-22 05:11:04]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 05:12:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[leonhsl(Using Gerrit), 2017-02-22 05:17:06]

Patchset #2 (id:60001) has been deleted

[leonhsl(Using Gerrit), 2017-02-22 05:17:13]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 05:18:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 06:17:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 06:17:56]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[leonhsl(Using Gerrit), 2017-02-22 07:37:55]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 07:39:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[leonhsl(Using Gerrit), 2017-02-22 09:15:38]

Patchset #2 (id:80001) has been deleted

[leonhsl(Using Gerrit), 2017-02-22 09:23:56]

Uploaded ps#2 to fix win trybots, PTAnL, Thanks!

[commit-bot: I haz the power, 2017-02-22 10:47:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 10:47:22]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2017-02-22 16:48:16]

Still LGTM

https://codereview.chromium.org/2705073003/diff/100001/content/renderer/histo...
File content/renderer/history_entry.h (right):

https://codereview.chromium.org/2705073003/diff/100001/content/renderer/histo...
content/renderer/history_entry.h:86: DISALLOW_COPY_AND_ASSIGN(HistoryNode);
Yep, I've seen this on Windows builds before... :)

[leonhsl(Using Gerrit), 2017-02-23 01:52:33]

Thanks! Send to CQ now.

https://codereview.chromium.org/2705073003/diff/100001/content/renderer/histo...
File content/renderer/history_entry.h (right):

https://codereview.chromium.org/2705073003/diff/100001/content/renderer/histo...
content/renderer/history_entry.h:86: DISALLOW_COPY_AND_ASSIGN(HistoryNode);
On 2017/02/22 16:48:15, Avi wrote:
> Yep, I've seen this on Windows builds before... :)

Sometimes Windows is special:-)

[leonhsl(Using Gerrit), 2017-02-23 01:52:39]

The CQ bit was checked by leon.han@intel.com

[commit-bot: I haz the power, 2017-02-23 01:53:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 02:04:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 02:04:07]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[leonhsl(Using Gerrit), 2017-02-23 02:45:05]

The CQ bit was checked by leon.han@intel.com

[leonhsl(Using Gerrit), 2017-02-23 02:45:06]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org
Link to the patchset: https://codereview.chromium.org/2705073003/#ps120001
(title: "Rebase only")

[commit-bot: I haz the power, 2017-02-23 02:45:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 04:13:40]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1487817905849390,
"parent_rev": "c4d7eaed0fcac839f1fd4f2a763bcb1ee52fd227", "commit_rev":
"21e0e489169ec98a36540905cf7c78ba907b7910"}

[commit-bot: I haz the power, 2017-02-23 04:14:49]

Description was changed from

==========
Remove ScopedVector from content/renderer/.

base::ScopedVector is deprecated, see bug.

BUG=554289
==========

to

==========
Remove ScopedVector from content/renderer/.

base::ScopedVector is deprecated, see bug.

BUG=554289

Review-Url: https://codereview.chromium.org/2705073003
Cr-Commit-Position: refs/heads/master@{#452388}
Committed:
https://chromium.googlesource.com/chromium/src/+/21e0e489169ec98a36540905cf7c...
==========

[commit-bot: I haz the power, 2017-02-23 04:14:54]

Committed patchset #3 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/21e0e489169ec98a36540905cf7c...

[Nico, 2017-02-23 20:30:32]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2017-02-23 20:30:33]

Looks like this breaks component builds on windows release,
https://bugs.chromium.org/p/chromium/issues/detail?id=695584

Probably best to revert while that's being figured out?

[Nico, 2017-02-23 21:02:05]

looks like hans has a fix: https://codereview.chromium.org/2712913003/

On Thu, Feb 23, 2017 at 3:30 PM, <thakis@chromium.org> wrote:

> Looks like this breaks component builds on windows release,
> https://bugs.chromium.org/p/chromium/issues/detail?id=695584
>
> Probably best to revert while that's being figured out?
>
> https://codereview.chromium.org/2705073003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.