Chromium Code Reviews
DescriptionFix flaky test WebRtcMediaRecorderTest.PeerConnection
A previous CL changed from logging to DCHECKing when setting minimum playout delay on a VoE channel: https://codereview.webrtc.org/2452163004/
I thought it safe at the time, since the input parameter range is capped, but apparently I didn't dig deep enough, as ultimately a failure may be returned for other reasons: https://chromium.googlesource.com/external/webrtc/+/master/webrtc/modules/audio_coding/neteq/delay_manager.cc#381
Thus, reverting to old behavior.
BUG=694373
Review-Url: https://codereview.webrtc.org/2704933008
Cr-Commit-Position: refs/heads/master@{#16775}
Committed: https://chromium.googlesource.com/external/webrtc/+/0335e6c4bfa9a3254a392c003344c71238ee832f
Patch Set 1 #Patch Set 2 : now it builds too #Messages
Total messages: 8 (4 generated)
|