Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2704933008: Fix flaky test WebRtcMediaRecorderTest.PeerConnection (Closed)

Created:
3 years, 10 months ago by the sun
Modified:
3 years, 10 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, henrika_webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix flaky test WebRtcMediaRecorderTest.PeerConnection A previous CL changed from logging to DCHECKing when setting minimum playout delay on a VoE channel: https://codereview.webrtc.org/2452163004/ I thought it safe at the time, since the input parameter range is capped, but apparently I didn't dig deep enough, as ultimately a failure may be returned for other reasons: https://chromium.googlesource.com/external/webrtc/+/master/webrtc/modules/audio_coding/neteq/delay_manager.cc#381 Thus, reverting to old behavior. BUG=694373 Review-Url: https://codereview.webrtc.org/2704933008 Cr-Commit-Position: refs/heads/master@{#16775} Committed: https://chromium.googlesource.com/external/webrtc/+/0335e6c4bfa9a3254a392c003344c71238ee832f

Patch Set 1 #

Patch Set 2 : now it builds too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M webrtc/voice_engine/channel_proxy.cc View 1 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
the sun
3 years, 10 months ago (2017-02-22 10:26:44 UTC) #2
hlundin-webrtc
lgtm
3 years, 10 months ago (2017-02-22 13:10:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2704933008/20001
3 years, 10 months ago (2017-02-22 13:44:31 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 15:07:11 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/0335e6c4bfa9a3254a392c003...

Powered by Google App Engine
This is Rietveld 408576698