Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1488)

Issue 2704343004: Remove unused variables from MetricRecorder. (Closed)

Created:
3 years, 10 months ago by terelius
Modified:
3 years, 9 months ago
Reviewers:
nisse-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove unused variables from MetricRecorder. BUG=webrtc:7209 Review-Url: https://codereview.webrtc.org/2704343004 Cr-Commit-Position: refs/heads/master@{#16831} Committed: https://chromium.googlesource.com/external/webrtc/+/f18847fa6a22fdb19edbc213c0603c021ac1a012

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove unused dependencies and old comment. #

Patch Set 3 : Don't change dependencies for video_test_common #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M webrtc/modules/remote_bitrate_estimator/BUILD.gn View 1 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/metric_recorder.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 21 (17 generated)
terelius
3 years, 10 months ago (2017-02-22 14:01:48 UTC) #4
nisse-webrtc
lgtm % nit. https://codereview.webrtc.org/2704343004/diff/1/webrtc/modules/remote_bitrate_estimator/test/metric_recorder.cc File webrtc/modules/remote_bitrate_estimator/test/metric_recorder.cc (left): https://codereview.webrtc.org/2704343004/diff/1/webrtc/modules/remote_bitrate_estimator/test/metric_recorder.cc#oldcode311 webrtc/modules/remote_bitrate_estimator/test/metric_recorder.cc:311: // Prevent the error to be ...
3 years, 10 months ago (2017-02-22 14:06:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2704343004/40001
3 years, 9 months ago (2017-02-24 16:43:01 UTC) #18
commit-bot: I haz the power
3 years, 9 months ago (2017-02-24 16:45:40 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/f18847fa6a22fdb19edbc213c...

Powered by Google App Engine
This is Rietveld 408576698